Bug 1879485: fix application selector incontext for add forms

[sahil143]

Fixes: https://issues.redhat.com/browse/ODC-2386

Analysis / Root cause: when the application is selected using the ApplicationSelector in the secondary masthead . Context for the selected application is not kept in the import forms

Solution Description: Keep the context of application

Screen shots / Gifs for design review: Coming soon

Unit test coverage report: None

Test setup:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@sahil143: This pull request references Bugzilla bug 1879485, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879485: fix application selector incontext for add forms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

Looks good, Verified locally seems to work as expected

[christianvogt]

The selector is still showing all applications when the last application is deleted in another browser.

[invincibleJai]

@sahil143 have verified again after fix , i see as below i.e even if user deletes app name from another browser still show's that application. That's the expected behaviour right?

[sahil143]

@sahil143 have verified again after fix , i see as below i.e even if user deletes app name from another browser still show's that application. That's the expected behaviour right?

Yes, That is expected behaviour

cc @christianvogt

[jerolimov]

Unfortunately this change means also that a deep link with the ?application parameter was not displayed correctly. But the new Deployment was created with the correct application anyway!

[christianvogt]

@jerolimov I don't see a difference in your scenario with this change or without. It seems like it's something we can handle in a separate issue. Do you mind creating a issue for this?

[christianvogt]

This improves the issue.
UX had some further suggestions that we can consider after further review.

[christianvogt]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@sahil143: All pull requests linked via external trackers have merged:

• openshift/console#6646

Bugzilla bug 1879485 has been moved to the MODIFIED state.

In response to this:

Bug 1879485: fix application selector incontext for add forms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/bugzilla refresh

[openshift-ci-robot]

@invincibleJai: Bugzilla bug 1879485 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.