Bug 1877822: The OS which already has a golden image can not be selected

[glekner]

Os with a golden image selected from a URL param or from the dropdown will have the following alert:

[openshift-ci-robot]

@glekner: This pull request references Bugzilla bug 1877822, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1877822: The OS which already has a golden image can not be selected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[glekner]

@yaacov can you review

[jelkosz]

@glekner you need to disable the controls on the screen when you pick an os which already has an image. Now I do see the error message but I can ignore it and attempt to do an upload and get

[matthewcarleton]

Os with a golden image selected from a URL param or from the dropdown will have the following alert:

So does that text within the dropdown change to default data image already exists when they select it? I don't think we need to change it if we are showing the alert.

[glekner]

@matthewcarleton @jelkosz
Tomas wrote in the BZ to keep the default data image already exists inside the dropdown. can we settle?

[matthewcarleton]

My opinion hasn’t changed :)
It feels strange to update the text in dropdown - I prefer the "source available" but let's hear @jelkosz thoughts

[jelkosz]

@matthewcarleton it does not change - it is there the whole time so I would keep it there. The "source available" feels like "everything is fine, source is available, feel free to pick me" while the "default data image already exists" feels like "dont touch this, it has already been configured" :)

[glekner]

Upload button is now disabled when the alert is shown @jelkosz

[yaacov]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matthewcarleton]

@matthewcarleton it does not change - it is there the whole time so I would keep it there. The "source available" feels like "everything is fine, source is available, feel free to pick me" while the "default data image already exists" feels like "dont touch this, it has already been configured" :)

ok I see your point. LGTM :)

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@glekner: All pull requests linked via external trackers have merged:

• openshift/console#6649

Bugzilla bug 1877822 has been moved to the MODIFIED state.

In response to this:

Bug 1877822: The OS which already has a golden image can not be selected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.