Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1872147: Disable health checks if BMO is not running or there's no power mgmt #6664

Merged
merged 1 commit into from Sep 24, 2020
Merged

Bug 1872147: Disable health checks if BMO is not running or there's no power mgmt #6664

merged 1 commit into from Sep 24, 2020

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Sep 17, 2020 •
edited

Depends on #6662

Screenshot from 2020-09-17 11-19-21
Screenshot from 2020-09-17 11-20-18

@andybraren Is this ok or do we want more descriptive messages ? maybe in popup ?

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1872147, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872147: Disable health checks if BMO is not running or there's no power mgmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/metal3 Related to metal3-plugin label Sep 17, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1872147, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872147: Disable health checks if BMO is not running or there's no power mgmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jtomasek
jtomasek approved these changes Sep 17, 2020
View reviewed changes
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@rawagner
Copy link
Contributor Author

/hold
lets wait for @andybraren

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@andybraren
Copy link
Contributor

I think we probably do want to keep the popover, which includes an explanation of what Health Checks are, provides more room to explain why it's not available, and could provide a link to add IPMI credentials or (eventually) configure the BMO.

The substatus in the card in either of these states could be:

Health Checks
Not available

If power management isn't available, maybe we could tweak the inline alert wording we used in #5885 slightly to be:

Health Checks
Machine Health Checks automatically remediate node health issues.

[neutral-alert]
Power management not available
Power operations cannot be performed on this node until Baseboard Management Controller (BMC) credentials are provided for the underlying host.
Add credentials
[/neutral-alert]

And if the Bare Metal Operator isn't available, the inline alert could be:

Health Checks
Machine Health Checks automatically remediate node health issues.

[neutral-alert]
Bare Metal Operator not available
The Bare Metal Operator that enables this capability is not available or disabled.
Configure operator [do we have a link to YAML or some other page that we could link to for now?]
[/neutral-alert]

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality and removed lgtm Indicates that a PR is ready to be merged. labels Sep 21, 2020
@rawagner
Copy link
Contributor Author

@andybraren makes sense, fixed
Screenshot from 2020-09-24 10-21-33

Screenshot from 2020-09-24 10-32-04

@rawagner
Copy link
Contributor Author

/retest

andybraren
andybraren approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@andybraren andybraren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm! Hopefully we can add a Configure operator action once we figure out where to send them.

@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@jtomasek
Copy link

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, jtomasek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 301bfb8 into openshift:master Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: All pull requests linked via external trackers have merged:

Bugzilla bug 1872147 has been moved to the MODIFIED state.

In response to this:

Bug 1872147: Disable health checks if BMO is not running or there's no power mgmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtomasek jtomasek jtomasek approved these changes

@andybraren andybraren andybraren approved these changes

@honza honza Awaiting requested review from honza

Assignees

@jtomasek jtomasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rawagner @openshift-ci-robot @andybraren @jtomasek @spadgett @openshift-merge-robot