Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880629: Fixes support for pre-provisioned snapshots #6679

Merged
merged 1 commit into from Sep 18, 2020
Merged

Bug 1880629: Fixes support for pre-provisioned snapshots #6679

merged 1 commit into from Sep 18, 2020

Conversation

bipuladh
Copy link
Contributor

Screenshots after fix:
Screenshot from 2020-09-18 21-14-32
Screenshot from 2020-09-18 21-13-34

cc @andybraren

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 18, 2020
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Sep 18, 2020
@andybraren
Copy link
Contributor

WRT renaming the PVC column to Source in the table, I think that makes sense since the column can have both PVC's and VSC's within it. I believe OpenShift Virtualization uses the word Source for a similar reason in their Templates area. FYI @yuvalgalanti @shirimordechay

cloudbehl
cloudbehl reviewed Sep 18, 2020
View reviewed changes
frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx Outdated
{snapshotClass ? (
<ResourceLink
kind={referenceForModel(VolumeSnapshotClassModel)}
name={obj?.spec?.volumeSnapshotClassName}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name={obj?.spec?.volumeSnapshotClassName}
name={snapshotClass}

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx Outdated
const sourceKind = obj?.spec?.source?.persistentVolumeClaimName
? PersistentVolumeClaimModel.kind
: referenceForModel(VolumeSnapshotContentModel);
const sourceName =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const sourceName =
const sourceName = snapshotSource(obj);

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-details.tsx Outdated
const sourceKind = obj?.spec?.source?.persistentVolumeClaimName
? PersistentVolumeClaimModel.kind
: referenceForModel(VolumeSnapshotContentModel);
const sourceName =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const sourceName =
const sourceName =snapshotSource(obj);

@bipuladh bipuladh force-pushed the fix_vol_snaps branch 2 times, most recently from 8b3264c to d5c89ce Compare September 18, 2020 17:29
TheRealJon
TheRealJon requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new, but for consistency, this details page should use the DetailsItem component. Recommend opening a tech debt story for that.

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-details.tsx Outdated Show resolved Hide resolved
frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-details.tsx Outdated Show resolved Hide resolved
frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot-details.tsx Outdated Show resolved Hide resolved
TheRealJon
TheRealJon approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@bipuladh bipuladh changed the title Fixes support for pre-provisioned snapshots Bug 1880629: Fixes support for pre-provisioned snapshots Sep 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1880629, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1880629: Fixes support for pre-provisioned snapshots

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1880629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 18, 2020
spadgett
spadgett approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 63eace3 into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged:

Bugzilla bug 1880629 has been moved to the MODIFIED state.

In response to this:

Bug 1880629: Fixes support for pre-provisioned snapshots

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon TheRealJon approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @andybraren @openshift-ci-robot @spadgett @cloudbehl @TheRealJon @openshift-merge-robot