Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1881516: fix topology failing to load after installing a Helm Chart #6710

Merged
merged 1 commit into from Sep 23, 2020
Merged

Bug 1881516: fix topology failing to load after installing a Helm Chart #6710

merged 1 commit into from Sep 23, 2020

Conversation

debsmita1
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-4899
https://issues.redhat.com/browse/ODC-4900

Root Analysis:
For some charts, the chart manifest data can return null objects

Solution Description:
Removing the null objects from the helm manifest data before passing it in the map

GIF:
helm-fix

@debsmita1
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 22, 2020
@debsmita1
Copy link
Contributor Author

/assign @rohitkrai03

@debsmita1 debsmita1 changed the title fix topology failing to load after installing a Helm Chart Bug 1881516: fix topology failing to load after installing a Helm Chart Sep 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1881516, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1881516: fix topology failing to load after installing a Helm Chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jeff-phillips-18
jeff-phillips-18 reviewed Sep 22, 2020
View reviewed changes
frontend/packages/dev-console/src/components/helm/details/resources/HelmReleaseResources.tsx Outdated
@@ -24,6 +25,7 @@ export interface HelmReleaseResourcesProps {
const HelmReleaseResources: React.FC<HelmReleaseResourcesProps> = ({ match, customData }) => {
const namespace = match.params.ns;
const helmManifest = customData ? safeLoadAll(customData.manifest) : [];
_.remove(helmManifest, _.isNull);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather use filter than introduce lodash here.

frontend/packages/dev-console/src/components/topology/helm/helm-data-transformer.ts Outdated
@@ -165,6 +166,7 @@ const getHelmReleaseMap = (namespace: string) => {
releases.reduce((acc, release) => {
try {
const manifestResources: K8sResourceKind[] = safeLoadAll(release.manifest);
_.remove(manifestResources, _.isNull);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@jeff-phillips-18
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
rohitkrai03
rohitkrai03 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jeff-phillips-18, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@debsmita1
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1881516, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7abea87 into openshift:master Sep 23, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: All pull requests linked via external trackers have merged:

Bugzilla bug 1881516 has been moved to the MODIFIED state.

In response to this:

Bug 1881516: fix topology failing to load after installing a Helm Chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees

@rohitkrai03 rohitkrai03

@jeff-phillips-18 jeff-phillips-18

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@debsmita1 @openshift-ci-robot @jeff-phillips-18 @openshift-bot @rohitkrai03 @spadgett @openshift-merge-robot