Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1877739: Update git repo unreachable error to warning and better msg #6728

Merged
merged 1 commit into from Sep 24, 2020
Merged

Bug 1877739: Update git repo unreachable error to warning and better msg #6728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/packages/dev-console/src/components/import/git/GitSection.tsx
View file
Open in desktop
Expand Up @@ -77,7 +77,7 @@ const GitSection: React.FC<GitSectionProps> = ({ showSample, builderImages }) =>
} else {
setFieldValue('image.recommended', '');
setFieldValue('image.couldNotRecommend', false);
setValidated(ValidatedOptions.error);
setValidated(ValidatedOptions.warning);
}
},
[
Expand Down Expand Up @@ -151,8 +151,8 @@ const GitSection: React.FC<GitSectionProps> = ({ showSample, builderImages }) =>
if (validated === ValidatedOptions.success) {
return 'Validated';
}
if (validated === ValidatedOptions.error) {
return 'Git repository is not reachable.';
if (validated === ValidatedOptions.warning) {
return 'URL is valid but cannot be reached. If this is a private repository, enter a source secret in Advanced Git Options';
}
return '';
};
Expand Down