Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1879911: (security) dont use the hardcoded passwords #6747

Merged
merged 2 commits into from Sep 25, 2020
Merged

Bug 1879911: (security) dont use the hardcoded passwords #6747

merged 2 commits into from Sep 25, 2020

Conversation

atiratree
Copy link
Member

this PR supeseedes #6690

Gilad Lekner and others added 2 commits September 24, 2020 17:05
Fixes 1879911: (security) dont use the hardcoded passwords
49e9de4
@suomiy
set password only when necessary
a407b88 
- fix password generation
- rewrite the disk name and don't use the original one
- support form selection
@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1879911, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879911: (security) dont use the hardcoded passwords

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@jelkosz
Copy link

jelkosz commented Sep 25, 2020

/hold
looks like it breaks the chpasswd section of the cloud init

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2020
@jelkosz
Copy link

jelkosz commented Sep 25, 2020

/hold cancel
sorry, false alarm, it is still a valid yaml and it does work with cloudinit

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit a99e5c7 into openshift:master Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@suomiy: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1879911 has not been moved to the MODIFIED state.

In response to this:

Bug 1879911: (security) dont use the hardcoded passwords

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 25, 2020
Merged
@spadgett spadgett added this to the v4.6 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@atiratree @openshift-ci-robot @rawagner @jelkosz @spadgett @openshift-merge-robot @suomiy