Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1883080: add legends under devconsole monitoring dashboard graphs #6754

Merged
merged 1 commit into from Sep 28, 2020

Conversation

vikram-raj
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-3558

Analysis / Root cause:
The charts on the dashboard do not have legends. This makes it hard to tell which objects are represented.

Solution Description:
added legends under dev console monitoring dashboard graphs

Screen shots / Gifs for design review:
Screenshot 2020-09-28 at 8 02 47 AM

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@kyoto
Copy link
Member

kyoto commented Sep 28, 2020

/lgtm
CC @spadgett

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2020
@vikram-raj
Copy link
Member Author

/retitle Bug 1883080: add legends under devconsole monitoring dashboard graphs

@openshift-ci-robot openshift-ci-robot changed the title add legends under devconsole monitoring dashboard graphs Bug 1883080: add legends under devconsole monitoring dashboard graphs Sep 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 28, 2020
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Bugzilla bug 1883080, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1883080: add legends under devconsole monitoring dashboard graphs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit ce1e950 into openshift:master Sep 28, 2020
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: All pull requests linked via external trackers have merged:

Bugzilla bug 1883080 has been moved to the MODIFIED state.

In response to this:

Bug 1883080: add legends under devconsole monitoring dashboard graphs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the odc-3558 branch September 28, 2020 06:24
@vikram-raj
Copy link
Member Author

/cherry-pick release-4.5

@openshift-cherrypick-robot

@vikram-raj: new pull request created: #6755

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants