New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1883595: Fix chart merging and show chart provider in catalog #6761
Bug 1883595: Fix chart merging and show chart provider in catalog #6761
Conversation
/hold |
7db1bd1
to
72d2674
Compare
frontend/packages/dev-console/src/components/helm/form/HelmChartVersionDropdown.tsx
Outdated
Show resolved
Hide resolved
72d2674
to
e04b064
Compare
e04b064
to
6a7a35e
Compare
@rohitkrai03 Tried it out locally, works fine for me. Will add LGTM once we have UX approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
lgtm! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, parvathyvr, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rohitkrai03: This pull request references Bugzilla bug 1883595, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/hold cancel |
@rohitkrai03: All pull requests linked via external trackers have merged: Bugzilla bug 1883595 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Depends on: #6753
Fixes: https://issues.redhat.com/browse/ODC-4898
Analysis / Root cause: The helm charts were getting merged in backend for every chart repo. So, if there was a chart with same name coming from two different chart repos it would get merged and only come as one.
Solution Description: #6753 updates the merging logic and adds chart repo name to the key for each chart entry in index.yaml. UI parses this chart repo name from the key to display chart repo name as provider for the catalog item. Also updated the version merging logic.
This PR also changes the way we handle chart versions on install/upgrade form.
(Provided by Chart Repo Name)
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux @rachael-phillips @parvathyvr @serenamarie125
Unit test coverage report:
Test setup:
Build master with #6753
Browser conformance: