Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883737: Update Rotue section in Knative revision sidebar #6763

Merged
merged 1 commit into from Sep 30, 2020
Merged

Bug 1883737: Update Rotue section in Knative revision sidebar #6763

merged 1 commit into from Sep 30, 2020

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Sep 28, 2020 •
edited

Fixes: https://issues.redhat.com/browse/ODC-4879

Problem:
Revision/Service Route section in sidebar shows incorrect traffic percent for unique url.

Solution:
Update Route section in the knative Revision sidebar and service sidebar to have unique and base url information.
Screenshots:
Revision with unique tag:

image

Knative Service sidebar:

image

Test cases:
RoutesOverviewList:
image

RoutesOverveiwListItem
image
RevisionsOverveiwListItem
image
resource-overview-utils:
image

/kind bug
cc: @bgliwa01 @invincibleJai @openshift/team-devconsole-ux

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. component/knative Related to knative-plugin labels Sep 28, 2020
@bgliwa01
Copy link

The routes section when the knative service is selected should just be the first box with the location the splits should not be shown. I believe this is what was agreed on in the serverless meeting, right @invincibleJai ?

@invincibleJai
Copy link
Member

The routes section when the knative service is selected should just be the first box with the location the splits should not be shown. I believe this is what was agreed on in the serverless meeting, right @invincibleJai ?

Yes @bgliwa01 , for KSVC side we'll show just route with location and revisions section will show split percentage with unique route if any

@karthikjeeyar ^^

@karthikjeeyar
Copy link
Contributor Author

@bgliwa01 @invincibleJai Updated the code and screenshots to remove the split details in the routes section of KSVC sidebar.

bgliwa01
bgliwa01 approved these changes Sep 29, 2020
View reviewed changes
Copy link

@bgliwa01 bgliwa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karthikjeeyar karthikjeeyar force-pushed the fix-knative-sidebar branch 2 times, most recently from 4f70105 to d54f1c3 Compare September 30, 2020 04:14
@karthikjeeyar karthikjeeyar changed the title Update Rotue section in Knative revision sidebar Bug 1883737: Update Rotue section in Knative revision sidebar Sep 30, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Bugzilla bug 1883737, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883737: Update Rotue section in Knative revision sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai
invincibleJai reviewed Sep 30, 2020
View reviewed changes
frontend/packages/knative-plugin/src/utils/resource-overview-utils.ts Outdated
const tData = trafficData.filter(filterTrafficBasedOnResource(resource)).reduce(
(acc, traffic: Traffic) => {
traffic.url && acc.urls.push(traffic.url);
acc.percent += traffic.percent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : good to have check here as well

@invincibleJai
Copy link
Member

/approve

Verified the changes looks good!!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
sahil143
sahil143 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified changes locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgliwa01, invincibleJai, karthikjeeyar, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karthikjeeyar
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Bugzilla bug 1883737, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2ebd8ba into openshift:master Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: All pull requests linked via external trackers have merged:

Bugzilla bug 1883737 has been moved to the MODIFIED state.

In response to this:

Bug 1883737: Update Rotue section in Knative revision sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invincibleJai invincibleJai invincibleJai left review comments

@sahil143 sahil143 sahil143 approved these changes

@bgliwa01 bgliwa01 bgliwa01 approved these changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@karthikjeeyar @bgliwa01 @invincibleJai @openshift-ci-robot @sahil143 @spadgett @openshift-merge-robot