Bug 1878676: Add resource badges to application groups in topology list view

[jeff-phillips-18]

Fixes
https://issues.redhat.com/browse/ODC-4877

Description
Adds a resource badge to the application groups in the topology list view.
Change the name from 'unassigned' to 'no application group' in the application selectors and the list view heading.
Do not show the 'no application group' heading when there are no application groups.

Screenshots

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug

/cc @bgliwa01 @beaumorley @serenamarie125

[openshift-ci-robot]

@jeff-phillips-18: This pull request references Bugzilla bug 1878676, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1878676: Add resource badges to application groups in topology list view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bgliwa01]

lgtm

[debsmita1]

tried this out locally
/lgtm

[andrewballantyne]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, bgliwa01, debsmita1, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andrewballantyne]

/bugzilla refresh

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1878676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jeff-phillips-18: All pull requests linked via external trackers have merged:

• openshift/console#6766

Bugzilla bug 1878676 has been moved to the MODIFIED state.

In response to this:

Bug 1878676: Add resource badges to application groups in topology list view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

Everywhere else we use the badges, it's for a Kubernetes resource. Is it confusing to add a badge to something that's not a resource? (I assume here that the application groups are controlled by labels on the resources.)

[andrewballantyne]

Everywhere else we use the badges, it's for a Kubernetes resource. Is it confusing to add a badge to something that's not a resource? (I assume here that the application groups are controlled by labels on the resources.)

We already use it on the Topology screen, this is just carrying it over to the list view (which is also the workloads view in Admin => Projects => Workloads)

eg:

[spadgett]

I guess I have the same concern about that context :) But it looks like that is something we've already added in a previous release.

[andrewballantyne]

@spadgett We absolutely welcome the feedback :) I was merely stating it wasn't "new" for this situation... it was a mirror of content we already have. This was decided back in 4.3(?) to add it to the Topology graph view.

cc @christianvogt for awareness.

[christianvogt]

I guess I have the same concern about that context :) But it looks like that is something we've already added in a previous release.

Feedback goes to @serenamarie125 :)