Bug 1878873 : cypress-cucumber-automation-framework #6776

makambalaji · 2020-09-29T10:54:15Z

As per the comments mentioned in PR : #6618, splitting PR into small pr's
jira Id : ODC-4926
Tracking the addition of data-test attributes to the dev-console code using JIRA id : ODC-4937

makambalaji · 2020-09-29T10:58:43Z

/assign @dtaylor113

dtaylor113

Hi @makambalaji, thanks for breaking down this PR to a smaller size. I think we still need to work on using common helper methods, and if they do not meet some needs, enahnce the already existing ones. -thanks

Also please link a Bugzilla or JIRA story to this PR which will keep track of removing all the css selectors. - thanks

frontend/package.json

frontend/packages/dev-console/integration-tests/support/pages/add-flow/add-page.ts

frontend/packages/dev-console/integration-tests/support/commands/app.ts

frontend/packages/dev-console/integration-tests/support/pages/app.ts

frontend/packages/integration-tests-cypress/support/selectors.ts

frontend/packages/integration-tests-cypress/views/common.ts

frontend/packages/dev-console/integration-tests/reporter-config.json

frontend/packages/dev-console/integration-tests/support/pages/app.ts

frontend/package.json

frontend/packages/dev-console/integration-tests/README.md

frontend/package.json

dtaylor113

/lgtm thanks!

dtaylor113 · 2020-10-05T13:15:33Z

/approve

dtaylor113 · 2020-10-05T13:37:51Z

/lgtm

spadgett · 2020-10-05T14:32:33Z

frontend/package.json

+    "test-cypress-devconsole": "cd packages/dev-console/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
+    "test-cypress-devconsole-headless": "cd packages/dev-console/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/project-creation.feature\";",


Will these tests run as part of CI? Do they run if I use yarn run test-cypress-headless?

Yes, test-cypress-headless is now:
"test-cypress-headless": "yarn run test-cypress-console-headless && yarn run test-cypress-devconsole-headless",

But how will this scale if every package adds a test?

@makambalaji i thought you weren't planning to run all the dev-console tests on CI because you said it took hours to run.

@spadgett - From dev-console side, Will select the test scenarios for execution based on the tag names mentioned in cypress.json

@christianvogt - In CI, will run only smoke tests, now the execution time is also reduced from 2.5 hr to 1 hr.

This pr doesn't add 1hr of tests. I'd like to get the smoke tests down below 1hr down before adding all those tests.

But how will this scale if every package adds a test?

@spadgett I was envisioning teams adding to test-cypress-headless in the same manor. Teams need to cd to their cypress dir, so it seems to be the correct method.

andrewballantyne · 2020-10-05T16:22:51Z

@makambalaji frontend failed...

ESLint couldn't find the config "../.eslintrc" to extend from. Please check that the name of the config is correct.

The config "../.eslintrc" was referenced from the config file in "/go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/.eslintrc".

makambalaji · 2020-10-05T17:43:33Z

@makambalaji frontend failed...

ESLint couldn't find the config "../.eslintrc" to extend from. Please check that the name of the config is correct.
The config "../.eslintrc" was referenced from the config file in "/go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/.eslintrc".

@andrewballantyne : updated the eslintrc file

andrewballantyne · 2020-10-05T17:45:28Z

Re-adding the lgtm based on the linter change (last commit).

/lgtm

christianvogt · 2020-10-06T03:41:37Z

/approve

makambalaji · 2020-10-06T08:00:50Z

As per the openshift-ci-robot comments, assigning pr to Sam for approval
/assign @spadgett

dtaylor113 · 2020-10-06T13:22:11Z

/retest

makambalaji · 2020-10-06T15:32:21Z

/retest

spadgett · 2020-10-06T16:41:59Z

/approve

But you need to run prettier :)

openshift-bot · 2020-10-30T12:48:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-30T13:53:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dtaylor113 · 2020-10-30T14:03:46Z

/hold so openshift-bot doesn't continually try to /retest and PR fills up with failed messages.

Failure seems to be this:

2020/10/30 12:29:58 Container test in pod frontend failed, exit code 1, reason Error
2020/10/30 12:29:58 No custom metadata found and prow metadata already exists. Not updating the metadata.
2020/10/30 12:29:58 Ran for 7m31s
error: some steps failed:
  * could not run steps: step frontend failed: test "frontend" failed: the pod ci-op-x0h566h0/frontend failed after 7m30s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 1, reason Error

christianvogt · 2020-10-30T15:54:33Z

@makambalaji please update yarn.lock:

dtaylor113 · 2020-10-30T16:02:34Z

Hi @makambalaji,
The yarn.lock issue is causing the CI failure due to this check. The yarn.lock has changed in master so the yarn.lock included in this PR is probably stale. You will need to rebase, build the frontend again, then include the resulting yarn.lock in this PR. -thanks

makambalaji · 2020-11-02T11:03:24Z

/retest

dtaylor113

/lgtm

dtaylor113 · 2020-11-02T13:53:27Z

/hold cancel

dtaylor113 · 2020-11-02T18:11:34Z

/hold until #7053 merges!

Apologies @makambalaji, there was a CI regression when we added OLM Cyrpess tests and we were blocking the cluster-authentication-operator repo from completing PR merges. #7053 fixes this regression.

Once #7053 merges you will need to uncomment this, and resolve merge conflicts in package.json (test-cypress-headless script should be removed/deleted) -thanks

dtaylor113 · 2020-11-03T13:41:03Z

test-prow-e2e.sh

@@ -17,7 +17,7 @@ trap copyArtifacts EXIT

 # don't log kubeadmin-password
 set +x
-BRIDGE_KUBEADMIN_PASSWORD="$(cat "${INSTALLER_DIR}/auth/kubeadmin-password")"
+BRIDGE_KUBEADMIN_PASSWORD="$(cat "${KUBEADMIN_PASSWORD_FILE:-${INSTALLER_DIR}/auth/kubeadmin-password}")"


Why is this change neccesary? Where is KUBEADMIN_PASSWORD_FILE set?

Somehow it got added, Now I removed it, Could you please review it now

updated Read-Me document, package.json and Report file name updated test attributes in add page.ts and added data test atttibutes in dev code for monitoring page commented a11y vaidations and raised the defects for the same Updated .git-ignore with package-lock.json because it is not listed in our dependencies

dtaylor113

/lgtm Thanks @makambalaji !

dtaylor113 · 2020-11-03T14:30:52Z

/hold cancel

andrewballantyne · 2020-11-03T15:22:48Z

/lgtm
(Dave's LGTM wasn't caught by the bot)

openshift-ci-robot · 2020-11-03T15:23:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, dtaylor113, makambalaji, sanketpathak, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-03T19:29:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-03T19:55:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from rhamilto and sanketpathak September 29, 2020 10:54

makambalaji mentioned this pull request Sep 29, 2020

Bug 1878873: add flow automation scripts #6618

Closed

openshift-ci-robot assigned dtaylor113 Sep 29, 2020

dtaylor113 requested changes Sep 29, 2020

View reviewed changes

dtaylor113 reviewed Sep 30, 2020

View reviewed changes

frontend/packages/integration-tests-cypress/views/common.ts Outdated Show resolved Hide resolved

dtaylor113 reviewed Sep 30, 2020

View reviewed changes

frontend/packages/dev-console/integration-tests/reporter-config.json Outdated Show resolved Hide resolved

dtaylor113 reviewed Sep 30, 2020

View reviewed changes

frontend/packages/dev-console/integration-tests/support/pages/app.ts Show resolved Hide resolved

dtaylor113 reviewed Sep 30, 2020

View reviewed changes

frontend/package.json Outdated Show resolved Hide resolved

openshift deleted a comment from makambalaji Oct 1, 2020

dtaylor113 reviewed Oct 1, 2020

View reviewed changes

frontend/packages/dev-console/integration-tests/README.md Show resolved Hide resolved

dtaylor113 reviewed Oct 1, 2020

View reviewed changes

frontend/package.json Outdated Show resolved Hide resolved

dtaylor113 approved these changes Oct 5, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020

spadgett reviewed Oct 5, 2020

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020

openshift-ci-robot assigned andrewballantyne Oct 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020

openshift-ci-robot assigned spadgett Oct 6, 2020

dtaylor113 mentioned this pull request Oct 30, 2020

CONSOLE-2426: Cypress & Protractor: Optimized shell and yarn scripts #7053

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020

dtaylor113 approved these changes Nov 2, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2020

dtaylor113 requested changes Nov 3, 2020

View reviewed changes

dtaylor113 approved these changes Nov 3, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020

openshift-merge-robot merged commit 4a089a4 into openshift:master Nov 3, 2020

spadgett added this to the v4.7 milestone Nov 4, 2020

		"test-cypress-devconsole": "cd packages/dev-console/integration-tests && ../../../node_modules/.bin/cypress open --env openshift=true",
		"test-cypress-devconsole-headless": "cd packages/dev-console/integration-tests && node --max-old-space-size=4096 ../../../node_modules/.bin/cypress run --env openshift=true --browser ${BRIDGE_E2E_BROWSER_NAME:=chrome} --headless --spec \"features/project-creation.feature\";",

Bug 1878873 : cypress-cucumber-automation-framework #6776

Bug 1878873 : cypress-cucumber-automation-framework #6776

Conversation

makambalaji commented Sep 29, 2020 • edited

makambalaji commented Sep 29, 2020

dtaylor113 left a comment

Choose a reason for hiding this comment

dtaylor113 left a comment

Choose a reason for hiding this comment

dtaylor113 commented Oct 5, 2020

dtaylor113 commented Oct 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne commented Oct 5, 2020

makambalaji commented Oct 5, 2020

andrewballantyne commented Oct 5, 2020

christianvogt commented Oct 6, 2020

makambalaji commented Oct 6, 2020

dtaylor113 commented Oct 6, 2020

makambalaji commented Oct 6, 2020

spadgett commented Oct 6, 2020

openshift-bot commented Oct 30, 2020

openshift-bot commented Oct 30, 2020

dtaylor113 commented Oct 30, 2020

christianvogt commented Oct 30, 2020

dtaylor113 commented Oct 30, 2020 • edited

makambalaji commented Nov 2, 2020

dtaylor113 left a comment

Choose a reason for hiding this comment

dtaylor113 commented Nov 2, 2020

dtaylor113 commented Nov 2, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtaylor113 left a comment

Choose a reason for hiding this comment

dtaylor113 commented Nov 3, 2020

andrewballantyne commented Nov 3, 2020 • edited

openshift-ci-robot commented Nov 3, 2020

openshift-bot commented Nov 3, 2020

openshift-bot commented Nov 3, 2020

makambalaji commented Sep 29, 2020 •

edited

dtaylor113 commented Oct 30, 2020 •

edited

dtaylor113 commented Nov 2, 2020 •

edited

andrewballantyne commented Nov 3, 2020 •

edited