Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item #6777

Merged
merged 1 commit into from Sep 29, 2020
Merged

Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item #6777

merged 1 commit into from Sep 29, 2020

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Sep 29, 2020 •
edited

Fixes
https://issues.redhat.com/browse/ODC-4911

Description
Add the URI link to the list view row for the URI item.
Add the URI link to the header of the URI side panel details (move up from Resources)
Fix to scroll to initial selection for topology list view.

Screenshots
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

/cc @bgliwa01

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/knative Related to knative-plugin labels Sep 29, 2020
@jeff-phillips-18 jeff-phillips-18 changed the title Add uri value to URI list item and side bar, fix initial scroll to selected item Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1883479, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@bgliwa01
Copy link

Could you please change "Uri" in List view "URI"?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1883479, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-phillips-18
Copy link
Member Author

Updated to URI, updated screenshot above.

@divyanshiGupta Please take another look.

@divyanshiGupta
Copy link
Contributor

@jeff-phillips-18 the code looks good to me. Waiting for @bgliwa01's approval.

bgliwa01
bgliwa01 approved these changes Sep 29, 2020
View reviewed changes
Copy link

@bgliwa01 bgliwa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks Jeff

@divyanshiGupta
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
andrewballantyne
andrewballantyne reviewed Sep 29, 2020
View reviewed changes
frontend/packages/knative-plugin/src/topology/listView/SinkUriListViewNode.tsx Outdated

const labelCell = (
<DataListCell className="odc-topology-list-view__label-cell" key="label" id={sinkUri}>
{<TypedResourceBadgeCell key="type-icon" kind={item.getResourceKind()} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
{<TypedResourceBadgeCell key="type-icon" kind={item.getResourceKind()} />}
<TypedResourceBadgeCell key="type-icon" kind={item.getResourceKind()} />

andrewballantyne
andrewballantyne reviewed Sep 29, 2020
View reviewed changes
frontend/packages/knative-plugin/src/topology/listView/SinkUriListViewNode.tsx
const labelCell = (
<DataListCell className="odc-topology-list-view__label-cell" key="label" id={sinkUri}>
{<TypedResourceBadgeCell key="type-icon" kind={item.getResourceKind()} />}
{sinkUri}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does not find this, we are back to where we are with this bug 🤔

Not sure what we could put here though.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@andrewballantyne
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, bgliwa01, divyanshiGupta, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeff-phillips-18
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1883479, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 453662e into openshift:master Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: All pull requests linked via external trackers have merged:

Bugzilla bug 1883479 has been moved to the MODIFIED state.

In response to this:

Bug 1883479: Add uri value to URI list item and side bar, fix initial scroll to selected item

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the uri-label branch December 2, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@bgliwa01 bgliwa01 bgliwa01 approved these changes

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@andrewballantyne andrewballantyne

@divyanshiGupta divyanshiGupta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeff-phillips-18 @openshift-ci-robot @divyanshiGupta @bgliwa01 @andrewballantyne @spadgett @openshift-merge-robot