Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883918: Proposed fix for duplicate UpdateAvailable notifications in the notification drawer #6786

Merged
merged 1 commit into from Sep 30, 2020
Merged

Bug 1883918: Proposed fix for duplicate UpdateAvailable notifications in the notification drawer #6786

merged 1 commit into from Sep 30, 2020

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Sep 29, 2020 •
edited

Eliminate duplicate notification entries in the notification drawer to update a cluster. There is currently an ota alert named UpdateAvailalble and also a recommendation created from data in clusterversion. They provide duplicate info, and the solution proposed is to filter out the ota alert. This pr addresses that solution.

Before:
Screen Shot 2020-09-29 at 10 56 07 PM

After:
Screen Shot 2020-09-29 at 10 56 20 PM

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 29, 2020
@jcaianirh
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
spadgett
spadgett approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2020
dtaylor113
dtaylor113 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett changed the title Proposed fix for duplicate UpdateAvailable notifications in the notification drawer Bug 1883918: Proposed fix for duplicate UpdateAvailable notifications in the notification drawer Sep 30, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1883918, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1883918: Proposed fix for duplicate UpdateAvailable notifications in the notification drawer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 039e371 into openshift:master Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: All pull requests linked via external trackers have merged:

Bugzilla bug 1883918 has been moved to the MODIFIED state.

In response to this:

Bug 1883918: Proposed fix for duplicate UpdateAvailable notifications in the notification drawer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaianirh @openshift-ci-robot @spadgett @dtaylor113 @openshift-merge-robot