Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1884150: Fix timeout issue in ceph test suite #6790

Merged
merged 1 commit into from Oct 1, 2020
Merged

Bug 1884150: Fix timeout issue in ceph test suite #6790

merged 1 commit into from Oct 1, 2020

Conversation

ebondare
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Sep 30, 2020
@ebondare
Copy link
Contributor Author

/assign @gnehapk

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@ebondare ebondare changed the title Fix timeout issue in ceph test suite Bug 1884150: Fix timeout issue in ceph test suite Oct 1, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

@ebondare: This pull request references Bugzilla bug 1884150, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1884150: Fix timeout issue in ceph test suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh
bipuladh suggested changes Oct 1, 2020
View reviewed changes
...ph-storage-plugin/integration-tests/tests/2-tests/ocp-dashboard-card-healthcheck.scenario.ts Outdated
@@ -28,9 +28,9 @@ describe('Check health data on main OCP dashboard ', () => {
await browser.sleep(2 * SECOND);
expect(mainHealtYellowSvg.isPresent()).toBe(true);
noOutChange('unset');
jasmine.DEFAULT_TIMEOUT_INTERVAL = 300;
jasmine.DEFAULT_TIMEOUT_INTERVAL += 30 * SECOND;
await browser.wait(until.presenceOf(mainHealtGreenSvg));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await browser.wait(until.presenceOf(mainHealtGreenSvg));
await browser.wait(until.presenceOf(mainHealtGreenSvg), 60 * SECOND);

...ph-storage-plugin/integration-tests/tests/2-tests/ocp-dashboard-card-healthcheck.scenario.ts Outdated
@@ -28,9 +28,9 @@ describe('Check health data on main OCP dashboard ', () => {
await browser.sleep(2 * SECOND);
expect(mainHealtYellowSvg.isPresent()).toBe(true);
noOutChange('unset');
jasmine.DEFAULT_TIMEOUT_INTERVAL = 300;
jasmine.DEFAULT_TIMEOUT_INTERVAL += 30 * SECOND;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jasmine.DEFAULT_TIMEOUT_INTERVAL += 30 * SECOND;

...ph-storage-plugin/integration-tests/tests/2-tests/ocp-dashboard-card-healthcheck.scenario.ts Outdated
await browser.wait(until.presenceOf(mainHealtGreenSvg));
jasmine.DEFAULT_TIMEOUT_INTERVAL = 120;
jasmine.DEFAULT_TIMEOUT_INTERVAL -= 30 * SECOND;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jasmine.DEFAULT_TIMEOUT_INTERVAL -= 30 * SECOND;

bipuladh
bipuladh approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, ebondare, shyRozen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebondare
Copy link
Contributor Author

ebondare commented Oct 1, 2020

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit a8318a3 into openshift:master Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

@ebondare: All pull requests linked via external trackers have merged:

Bugzilla bug 1884150 has been moved to the MODIFIED state.

In response to this:

Bug 1884150: Fix timeout issue in ceph test suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyRozen shyRozen shyRozen approved these changes

@bipuladh bipuladh bipuladh approved these changes

@a2batic a2batic Awaiting requested review from a2batic

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@gnehapk gnehapk

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ebondare @openshift-ci-robot @shyRozen @bipuladh @spadgett @gnehapk @openshift-merge-robot