Bug 1883591: Support ServiceBinding breaking api changes

[divyanshiGupta]

Jira: https://issues.redhat.com/browse/ODC-4928

Analysis / Root cause:
Service Binding Operator (starting with v0.2.0) has changed API (CRD) redhat-developer/service-binding-operator#608 that is not supported in OCP 4.6 and hence service-binding is not working.

Solution Description:
Refactor code based on the latest API changes. Also fix failing unit tests accordingly

Gifs:
Create service-binding using:

1. Binding connector
   

2. Import YAML
   

PR Test setup:
Install community version of Service Binding from OperatorHub using the beta channel.

[openshift-ci-robot]

@divyanshiGupta: This pull request references Bugzilla bug 1883591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1883591: Support ServiceBinding breaking api changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianvogt]

@divyansh42 can we add support for both SBR and SB CRDs?
Keep old and new models.
Create a new feature flag for the SB.
Fetch both SBR and SB for topology and visualize them in the same way.
On creation, if the SB feature flag is set, create the SB, otherwise create the SBR.

How much additional work is needed to do the above?

[divyanshiGupta]

@divyansh42 can we add support for both SBR and SB CRDs?
Keep old and new models.
Create a new feature flag for the SB.
Fetch both SBR and SB for topology and visualize them in the same way.
On creation, if the SB feature flag is set, create the SB, otherwise create the SBR.

How much additional work is needed to do the above?

@christianvogt Shouldnt it be that the user can only install the operator from particular channels on particular OCP versions. For example version < = 4.5 operator will be installed using alpha channel and for version > 4.5 operator will be installed using beta channel. Here https://issues.redhat.com/browse/ODC-4928 there are some comments regarding having a single channel so I assume for particular versions we will have respective single channels.

And say if in future we have a new CRD so then we will support three CRDs for service-binding?

[christianvogt]

After discussing this further we will go with updating support for the new SB and dropping SBR in 4.6.

[christianvogt]

I've tested the the changes and creation and visualization of the SB work as expected.
/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@divyanshiGupta: All pull requests linked via external trackers have merged:

• openshift/console#6792

Bugzilla bug 1883591 has been moved to the MODIFIED state.

In response to this:

Bug 1883591: Support ServiceBinding breaking api changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianvogt]

/cherry-pick release-4.5

New SBO has been promoted to be the default for 4.5 as well.

[openshift-cherrypick-robot]

@christianvogt: #6792 failed to apply on top of branch "release-4.5":

Applying: Support ServiceBinding breaking api changes
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/topology/__tests__/service-binding-test-data.ts
M	frontend/packages/dev-console/src/components/topology/__tests__/topology-test-data.ts
A	frontend/packages/dev-console/src/components/topology/operators/actions/serviceBindings.ts
A	frontend/packages/dev-console/src/components/topology/operators/operator-resources.ts
M	frontend/packages/dev-console/src/components/topology/operators/operators-data-transformer.ts
A	frontend/packages/dev-console/src/components/topology/operators/operatorsTopologyPlugin.ts
M	frontend/packages/dev-console/src/plugin.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/plugin.tsx
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/topology/operators/operatorsTopologyPlugin.ts deleted in HEAD and modified in Support ServiceBinding breaking api changes. Version Support ServiceBinding breaking api changes of frontend/packages/dev-console/src/components/topology/operators/operatorsTopologyPlugin.ts left in tree.
Auto-merging frontend/packages/dev-console/src/components/topology/operators/operators-data-transformer.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/topology/operators/operators-data-transformer.ts
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/topology/operators/operator-resources.ts deleted in HEAD and modified in Support ServiceBinding breaking api changes. Version Support ServiceBinding breaking api changes of frontend/packages/dev-console/src/components/topology/operators/operator-resources.ts left in tree.
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/topology/operators/actions/serviceBindings.ts deleted in HEAD and modified in Support ServiceBinding breaking api changes. Version Support ServiceBinding breaking api changes of frontend/packages/dev-console/src/components/topology/operators/actions/serviceBindings.ts left in tree.
Auto-merging frontend/packages/dev-console/src/components/topology/__tests__/topology-test-data.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/topology/__tests__/topology-test-data.ts
Auto-merging frontend/packages/dev-console/src/components/topology/__tests__/service-binding-test-data.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/topology/__tests__/service-binding-test-data.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Support ServiceBinding breaking api changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

New SBO has been promoted to be the default for 4.5 as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.