Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1886766: Changes 'Persistent Volume' to 'Persistent Volume Claim' for PVC dropdown in snapshot create page #6796

Merged
merged 1 commit into from Oct 31, 2020
Merged

Bug 1886766: Changes 'Persistent Volume' to 'Persistent Volume Claim' for PVC dropdown in snapshot create page #6796

merged 1 commit into from Oct 31, 2020

Conversation

vbnrh
Copy link
Contributor

@vbnrh vbnrh commented Sep 30, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2020 •
edited

@vbnrh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 6030033 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vbnrh vbnrh changed the title Small fixes to snapshot Bug 1886766: Small fixes to snapshot Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

@vbnrh: This pull request references Bugzilla bug 1886766, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1886766: Small fixes to snapshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 9, 2020
@a2batic
Copy link
Contributor

a2batic commented Oct 12, 2020

@vbnrh the volume snapshot class dropdown looks like below when I am landing on create volume snapshot view, it's not pre-populating the dropdown for me:
Screenshot from 2020-10-12 17-58-37

a2batic
a2batic suggested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@a2batic a2batic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you might want to the new prop to to component type annotations, https://github.com/openshift/console/blob/master/frontend/public/components/utils/list-dropdown.jsx#L195

frontend/public/components/utils/list-dropdown.jsx Outdated Show resolved Hide resolved
frontend/public/components/utils/list-dropdown.jsx Outdated Show resolved Hide resolved
@vbnrh
Copy link
Contributor Author

vbnrh commented Oct 20, 2020

Also, you might want to the new prop to to component type annotations, https://github.com/openshift/console/blob/master/frontend/public/components/utils/list-dropdown.jsx#L195

Added

@afreen23
Copy link
Contributor

@vbnrh

The BZ talks different whats implemented in PR.
Lets cut down the scope.

Thanks!

@vbnrh
Changes persistent volume title to Persistent volume claim in the sna…
5d31329 
…pshot creation page

Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@vbnrh: This pull request references Bugzilla bug 1886766, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1886766: Small fixes to snapshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vbnrh
Copy link
Contributor Author

vbnrh commented Oct 29, 2020

@afreen23 @a2batic As suggested, I've just kept one commit to address the bug. I'll be sending out PRs for the other items

@a2batic
Copy link
Contributor

a2batic commented Oct 29, 2020

/lgtm
@rawagner please review

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@vbnrh vbnrh changed the title Bug 1886766: Small fixes to snapshot Bug 1886766: Changes 'Persistent Volume' to 'Persistent Volume Claim' for PVC dropdown in snapshot create page Oct 29, 2020
spadgett
spadgett approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, spadgett, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4c2ebf4 into openshift:master Oct 31, 2020
@openshift-ci-robot
Copy link
Contributor

@vbnrh: All pull requests linked via external trackers have merged:

Bugzilla bug 1886766 has been moved to the MODIFIED state.

In response to this:

Bug 1886766: Changes 'Persistent Volume' to 'Persistent Volume Claim' for PVC dropdown in snapshot create page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@a2batic a2batic a2batic requested changes

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@spadgett spadgett

@a2batic a2batic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vbnrh @openshift-ci-robot @a2batic @afreen23 @openshift-bot @spadgett @cloudbehl @openshift-merge-robot