New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1892653: update kafkaSource v1beta1 spec to remove resources #6828
Bug 1892653: update kafkaSource v1beta1 spec to remove resources #6828
Conversation
3c0e40f
to
f553025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@invincibleJai Tested locally, by installing KEK components alone. it works as expected, I dont see any issues with the changes. Before adding lgtm, I will test once with installing strimzi operator to see the working example.
Installed strimzi operator and Kafka source using KEK components and created the kafka source. I am able to produce events by running kafka producer and the knative service is able to receive the message @invincibleJai. Good Job!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@invincibleJai: All pull requests linked via external trackers have merged: Bugzilla bug 1892653 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@invincibleJai: Bugzilla bug 1892653 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@invincibleJai: Bugzilla bug 1892653 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4955
Analysis / Root cause:
User is unable to create KafkaSource with
v1beta
as resources / ServiceAccountName in spec is droppedSolution Description:
update kafkaSource v1beta1 spec to remove resources/ServiceAccount name
Screen shots / Gifs for design review:
Test setup:
knative-Eventing
Browser conformance: