Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1892653: update kafkaSource v1beta1 spec to remove resources #6828

Merged

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Oct 5, 2020

Fixes:
https://issues.redhat.com/browse/ODC-4955

Analysis / Root cause:
User is unable to create KafkaSource with v1beta as resources / ServiceAccountName in spec is dropped

Solution Description:
update kafkaSource v1beta1 spec to remove resources/ServiceAccount name

Screen shots / Gifs for design review:

Test setup:

  • Install Serverless operator, create CR for KnativeServing, KnativeEventing
  • Install knativa Kafka Operator, Install KEK CR in ns knative-Eventing

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Oct 5, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@invincibleJai Tested locally, by installing KEK components alone. it works as expected, I dont see any issues with the changes. Before adding lgtm, I will test once with installing strimzi operator to see the working example.

@karthikjeeyar
Copy link
Contributor

Installed strimzi operator and Kafka source using KEK components and created the kafka source. I am able to produce events by running kafka producer and the knative service is able to receive the message @invincibleJai. Good Job!!

Screenshot from 2020-10-06 12-03-32
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 90ec0f1 into openshift:master Oct 6, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 6, 2020
@invincibleJai invincibleJai changed the title update kafkaSource v1beta1 spec to remove resources Bug 1892653: update kafkaSource v1beta1 spec to remove resources Oct 29, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: All pull requests linked via external trackers have merged:

Bugzilla bug 1892653 has been moved to the MODIFIED state.

In response to this:

Bug 1892653: update kafkaSource v1beta1 spec to remove resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@invincibleJai: Bugzilla bug 1892653 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@invincibleJai: Bugzilla bug 1892653 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants