Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to retrieve pipeline data in topology when unsupported #6842

Merged
merged 1 commit into from Oct 9, 2020
Merged

Don't attempt to retrieve pipeline data in topology when unsupported #6842

merged 1 commit into from Oct 9, 2020

Conversation

jeff-phillips-18
Copy link
Member

Fixes
https://issues.redhat.com/browse/ODC-4971

Description
Do not attempt to retrieve pipeline resources for topology when not supported.
Non-functional change

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind cleanup

@openshift-ci-robot openshift-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. component/dev-console Related to dev-console labels Oct 5, 2020
@abhinandan13jan
Copy link
Contributor

needs rebase

@jerolimov
Copy link
Member

jerolimov commented Oct 9, 2020 •
edited

Learned from @jeff-phillips-18 that you can verify this change by debugging const resources = useK8sWatchResources in TopologyDataRetriever.tsx. You see there that we have an error for pipeline and pipelineRun when the Pipelines Operator is not installed before it doing a network call. Thanks for helping me here.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
andrewballantyne
andrewballantyne approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update, I sorta jammed Pipelines back in after that refactor :) Glad it found a proper extension home.

@andrewballantyne
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jeff-phillips-18, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit f12ee43 into openshift:master Oct 9, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 13, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the pipeline-retrieval branch December 2, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@nemesis09 nemesis09 Awaiting requested review from nemesis09

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeff-phillips-18 @abhinandan13jan @jerolimov @andrewballantyne @openshift-ci-robot @spadgett @openshift-merge-robot