Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds serving in admin to show services, revisions, routes as tab views #6848

Merged
merged 2 commits into from Oct 20, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Oct 6, 2020

Fixes:
https://issues.redhat.com/browse/ODC-4880

Analysis / Root cause:
Admin should see Serving under Serverless and all resources (services, revisions, routes) under it

Solution Description:

  • moved Serving under Serverless and all resources (services, revisions, routes) under it

Screen shots / Gifs for design review:

image

Gif:

Oct-07-2020 19-45-26

@openshift/team-devconsole-ux

Unit test coverage report:

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@invincibleJai invincibleJai changed the title adds serving in admin to show services, revisions, routes as tab views [WIP] adds serving in admin to show services, revisions, routes as tab views Oct 6, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/dev-console Related to dev-console labels Oct 6, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/shared Related to console-shared labels Oct 6, 2020
@invincibleJai invincibleJai force-pushed the odc-4880 branch 2 times, most recently from 2f61daa to 51cf243 Compare October 7, 2020 08:57
@invincibleJai invincibleJai changed the title [WIP] adds serving in admin to show services, revisions, routes as tab views adds serving in admin to show services, revisions, routes as tab views Oct 7, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2020
@bmignano
Copy link

bmignano commented Oct 7, 2020

LGTM!

Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice one issue, clicking on the details page breadcrumb should redirect back to the same tabbed list page. But currently, it is redirected back to the default list page.
Kapture 2020-10-08 at 16 20 16

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@invincibleJai
Copy link
Member Author

I notice one issue, clicking on the details page breadcrumb should redirect back to the same tabbed list page. But currently, it is redirected back to the default list page.

@vikram-raj thanks for highlighting, have updated PTAL

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @invincibleJai.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@invincibleJai
Copy link
Member Author

/assign @rohitkrai03

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me but found this bug that may not be related to this PR. Please take a look -

Peek 2020-10-15 17-15

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@invincibleJai
Copy link
Member Author

invincibleJai commented Oct 19, 2020

Code looks good to me but found this bug that may not be related to this PR. Please take a look -

Thanks @rohitkrai03 Similar behaviour is there for other flows(pod/task for pipelines) but yes there was an issue should show create Service. On ns change it shows list of service with Create option
Have fixed it PTAL

Oct-19-2020 19-52-25

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f66da1a into openshift:master Oct 20, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants