New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds serving in admin to show services, revisions, routes as tab views #6848
adds serving in admin to show services, revisions, routes as tab views #6848
Conversation
frontend/packages/knative-plugin/src/components/overview/serving-list/ServingListsPage.tsx
Outdated
Show resolved
Hide resolved
2f61daa
to
51cf243
Compare
frontend/packages/dev-console/src/components/pipelines-lists/PipelinesListsPage.tsx
Outdated
Show resolved
Hide resolved
51cf243
to
f55938e
Compare
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikram-raj thanks for highlighting, have updated PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @invincibleJai.
/lgtm
/assign @rohitkrai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d8e9e93
to
15107df
Compare
Thanks @rohitkrai03 Similar behaviour is there for other flows(pod/task for pipelines) but yes there was an issue should show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes:
https://issues.redhat.com/browse/ODC-4880
Analysis / Root cause:
Admin should see Serving under Serverless and all resources (services, revisions, routes) under it
Solution Description:
Screen shots / Gifs for design review:
Gif:
@openshift/team-devconsole-ux
Unit test coverage report:
Browser conformance: