New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1886353: Add amd64 URL for virtctl binary in kubevirt-gating job #6868
Bug 1886353: Add amd64 URL for virtctl binary in kubevirt-gating job #6868
Conversation
Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@irosenzw: This pull request references Bugzilla bug 1886353, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irosenzw, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@irosenzw: All pull requests linked via external trackers have merged: Bugzilla bug 1886353 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -50,7 +54,10 @@ EOF | |||
|
|||
# Install virtctl binary and add in to PATH | |||
mkdir virtctl | |||
wget https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/virtctl-${KUBEVIRT_VERSION}-linux-x86_64 -O virtctl/virtctl | |||
|
|||
wget ${VIRTCTL_AMD64} -O virtctl/virtctl || wget ${VIRTCTL_X86_64} -O virtctl/virtctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this line do ?
you download the amd-64 binary and then if the download fails you download the x86 one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner i may be missing something, can you take a look ^^
Signed-off-by: Ido Rosenzwig irosenzw@redhat.com