Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1886397: Move object-enum to console shared #6869

Merged
merged 1 commit into from Oct 8, 2020
Merged

Bug 1886397: Move object-enum to console shared #6869

merged 1 commit into from Oct 8, 2020

Conversation

irosenzw
Copy link
Contributor

@irosenzw irosenzw commented Oct 8, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Oct 8, 2020
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Oct 8, 2020
@irosenzw irosenzw changed the title Move object enum to console shared Bug 1886397: Move object-enum to console shared Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: This pull request references Bugzilla bug 1886397, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1886397: Move object-enum to console shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 8, 2020
@irosenzw irosenzw force-pushed the move-object-enum-to-console-shared branch from 9d36970 to a5a9451 Compare October 8, 2020 11:42
atiratree
atiratree reviewed Oct 8, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/modals/disk-modal/storage-ui-source.ts Outdated
@@ -15,6 +15,7 @@ import {
SelectDropdownData,
SelectDropdownObjectEnum,
} from '../../../constants/select-dropdown-object-enum';
import { ObjectEnum } from '@console/shared/src/constants/object-enum';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please move it to the beginning?

...ges/kubevirt-plugin/src/k8s/wrapper/common/k8s-resource-object-with-type-property-wrapper.ts Outdated
import { clearMetadata, clearRuntimeMetadata, initK8sObject, K8sInitAddon } from './util/k8s-mixin';
import { ObjectEnum } from '@console/shared/src/constants/object-enum';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+here

frontend/packages/kubevirt-plugin/src/utils/validations/template/template-validations.ts Outdated
import { CommonTemplatesValidation } from '../../../types/template';
import {
IntervalValidationResult,
MemoryIntervalValidationResult,
} from './interval-validation-result';
import { DiskBusValidationResult } from './disk-bus-validation-result';
import { isSetEqual } from '../../common';
import { ObjectEnum } from '@console/shared/src/constants/object-enum';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@irosenzw irosenzw force-pushed the move-object-enum-to-console-shared branch from a5a9451 to 10114d4 Compare October 8, 2020 12:08
@irosenzw
Bug 1886397: Move object-enum to console shared
5b4922b 
Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@irosenzw irosenzw force-pushed the move-object-enum-to-console-shared branch from 10114d4 to 5b4922b Compare October 8, 2020 12:20
@atiratree
Copy link
Member

@rawagner can you take a look?

@rawagner
Copy link
Contributor

rawagner commented Oct 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@atiratree
Copy link
Member

/test kubevirt-plugin

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a26b1fa into openshift:master Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: All pull requests linked via external trackers have merged:

Bugzilla bug 1886397 has been moved to the MODIFIED state.

In response to this:

Bug 1886397: Move object-enum to console shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@irosenzw @openshift-ci-robot @atiratree @rawagner @openshift-bot @spadgett @openshift-merge-robot