Bug 1886168: Hide Terminal tab from the NodeDetailsPage if Windows on the Node #6876
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@jhadvig: This pull request references Bugzilla bug 1886168, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
| <PodsPage showTitle={false} fieldSelector={`spec.nodeName=${obj.metadata.name}`} /> | ||
| )), | ||
| events(ResourceEventStream), | ||
| node?.metadata?.labels?.['node.openshift.io/os_id'] !== 'Windows' |
There was a problem hiding this comment.
Hi, @openshift/openshift-team-windows-containers is this the best label to check?
There was a problem hiding this comment.
@spadgett it was recommended in the BZ
There was a problem hiding this comment.
Correct...
We have node.openshift.io/os_id=Windows label attached to all the windows nodes that have joined the cluster
There was a problem hiding this comment.
Hi @jhadvig @spadgett sorry to offer conflicting information but other components have been using corev1.LabelOSStable to differentiate between Linux and Windows nodes. I think it is better to use this upstream label, rather than the OpenShift label.
There was a problem hiding this comment.
The expected value of LabelOSStable for Windows nodes is windows
There was a problem hiding this comment.
@sebsoto @PratikMahajan would it be safe to check both labels?
There was a problem hiding this comment.
The corev1 label should cover all cases as its applied by the kubelet, but I dont see any current harm by checking for either label with an or
| ); | ||
| const pagesFor = React.useCallback( | ||
| (node: NodeKind) => | ||
| _.compact([ |
There was a problem hiding this comment.
Instead of _.compact, we usually use this idiom:
[
foo,
bar,
...(showBaz ? [baz] : []),
]
|
@spadgett comment addressed :) |
|
@sebsoto @PratikMahajan added check for both labels per our conversation |
|
/test e2e-gcp-console |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhadvig: All pull requests linked via external trackers have merged: Bugzilla bug 1886168 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @spadgett