Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2392: i18n: externalize strings in Compute nav section #6929

Merged
merged 1 commit into from Nov 6, 2020
Merged

CONSOLE-2392: i18n: externalize strings in Compute nav section #6929

merged 1 commit into from Nov 6, 2020

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented Oct 14, 2020 •
edited by openshift-ci-robot

/assign @rhamilto
/cc @spadgett

FYI: The Node > Pods page makes use of the Workloads > Pods component, so it would be covered in Workloads.

Compute nav sub-section covered:

  1. Node
  2. Machine
  3. Machine Sets
  4. Machine Autoscaler
  5. Machine Heath Checks
  6. Machine Configs
  7. Machine Config Pools

CONSOLE-2392

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Oct 14, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch 8 times, most recently from 3f1fea0 to 20376fc Compare October 19, 2020 08:49
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/shared Related to console-shared labels Oct 19, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch 4 times, most recently from f88ccd4 to 8841f24 Compare October 19, 2020 14:43
@rhamilto
Copy link
Member

/retest

rhamilto
rhamilto reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't finish reviewing, but there are a number of changes that are needed already, so I'm going to go ahead and submit this review with the intention of coming back later (when it's not Bug Bash Monday).

frontend/packages/console-app/src/components/nodes/NodeDetailsConditions.tsx Outdated
@@ -5,21 +5,22 @@ import { SectionHeading, Timestamp, CamelCaseWrap } from '@console/internal/comp

type NodeDetailsConditionsProps = {
node: NodeKind;
t?: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and throughout the PR.

Suggested change
t?: any;
t: TFunction;

with import { TFunction } from 'i18next'; added on line 3.

frontend/packages/console-app/src/components/nodes/NodeDetailsOverview.tsx Outdated Show resolved Hide resolved
frontend/packages/console-app/src/components/nodes/NodeDetailsPage.tsx Outdated Show resolved Hide resolved
cyril-ui-developer
cyril-ui-developer commented Oct 19, 2020
View reviewed changes
Copy link
Contributor Author

@cyril-ui-developer cyril-ui-developer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't finish reviewing, but there are a number of changes that are needed already, so I'm going to go ahead and submit this review with the intention of coming back later (when it's not Bug Bash Monday).

@rhamilto That's fine. Will address those ones you have raised. Thanks

@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch 4 times, most recently from 003b59e to 662d8ca Compare October 20, 2020 12:26
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch from 662d8ca to 6a14185 Compare October 21, 2020 15:03
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch 2 times, most recently from c2e36f4 to 3dce553 Compare October 21, 2020 19:09
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Nov 4, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch 2 times, most recently from 8d307fc to a55c07f Compare November 4, 2020 17:11
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the i18n-externalize-strings-compute-nav-section branch from a55c07f to 9fa2c85 Compare November 4, 2020 18:35
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2020
spadgett
spadgett approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Nov 4, 2020

/retest

@yanpzhan
Copy link
Contributor

yanpzhan commented Nov 5, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Nov 5, 2020
@spadgett
Copy link
Member

spadgett commented Nov 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 9fa2c85 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 449ce28 into openshift:master Nov 6, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@yanpzhan yanpzhan yanpzhan left review comments

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@cyril-ui-developer @rhamilto @sferich888 @ahardin-rh @openshift-ci-robot @spadgett @yanpzhan @openshift-bot @openshift-merge-robot @yapei