Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Broker details page #6945

Merged
merged 1 commit into from Nov 18, 2020
Merged

Add Broker details page #6945

merged 1 commit into from Nov 18, 2020

Conversation

rottencandy
Copy link
Contributor

@rottencandy rottencandy commented Oct 15, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-4994
https://issues.redhat.com/browse/ODC-5062

Description:
Add a details page for Broker.
Add a list page for Triggers.

Screen shots / Gifs for design review:
tmp0
tmp1
@openshift/team-devconsole-ux @invincibleJai

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/dev-console Related to dev-console labels Oct 15, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/shared Related to console-shared labels Oct 15, 2020
@rottencandy rottencandy force-pushed the brokerdetails branch 3 times, most recently from b33959a to 2f5daee Compare November 3, 2020 13:34
@rottencandy rottencandy changed the title [WIP] Add Broker details page Add Broker details page Nov 3, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2020
sahil143
sahil143 reviewed Nov 3, 2020
View reviewed changes
frontend/packages/knative-plugin/src/components/eventing/triggers-list/TriggerListPage.tsx
canCreate={false}
{...props}
kind={referenceForModel(EventingTriggerModel)}
ListComponent={TriggerList}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the fieldSelector field here to filter our the triggers based on the broker name

fieldSelector={`spec.broker=${<broker name>}`}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fieldSelector seems to have issue with spec.broker, so will be going with current implementation.
Error Loading Triggers: field label not supported: spec.broker

frontend/packages/knative-plugin/src/components/eventing/triggers-list/TriggerRow.tsx Outdated
Comment on lines 25 to 26
if (customData?.broker && customData.broker === connectedBroker) {
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this if you use the fieldSelector

@rottencandy rottencandy force-pushed the brokerdetails branch 2 times, most recently from c0681c9 to 6617f23 Compare November 4, 2020 09:52
@rottencandy rottencandy force-pushed the brokerdetails branch 5 times, most recently from 4f222db to b7d9c34 Compare November 6, 2020 15:25
@invincibleJai
Copy link
Member

thanks @rottencandy looks good, will verify it once

@bmignano
Copy link

@rottencandy it seems like there might be some weird alignment issues with a few of the columns – other than that small fix it looks good to me!

@rottencandy rottencandy force-pushed the brokerdetails branch 2 times, most recently from 1b81ac4 to 3ba796d Compare November 10, 2020 16:16
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@rottencandy
Copy link
Contributor Author

Rebased.

@invincibleJai
Copy link
Member

/lgtm
/approve

Verified the changes , works as expected

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2020
@rottencandy
Copy link
Contributor Author

/retest

@invincibleJai
Copy link
Member

/test analyze

@invincibleJai
Copy link
Member

/retest

5 similar comments
@rottencandy
Copy link
Contributor Author

/retest

@rottencandy
Copy link
Contributor Author

/retest

@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

/retest

@rottencandy
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@rottencandy
Copy link
Contributor Author

Rebased.

@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rottencandy, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rottencandy
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bf96e10 into openshift:master Nov 18, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
@rottencandy rottencandy deleted the brokerdetails branch December 7, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@invincibleJai invincibleJai

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rottencandy @invincibleJai @bmignano @openshift-bot @openshift-ci-robot @sahil143 @spadgett @openshift-merge-robot