Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2428: i18n for search section of home nav #6948

Merged
merged 1 commit into from Oct 21, 2020

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Oct 15, 2020

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Oct 15, 2020
@jcaianirh
Copy link
Member Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we'll need QE review.

Note that I think there is still some work to do to properly lazy load the translations, but we need to investigate. That can be handled separately.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2020
@spadgett
Copy link
Member

@yapei This is ready for QE review. This PR only covers basic elements of the Home -> Search page like the title and toolbar. It does not cover the list contents itself, which will be handled separately for each resource type.

/assign @yapei @ahardin-rh @sferich888
for QE/docs/CEE approval

@jcaianirh jcaianirh changed the title CONSOLE-2370: i18n for search section of home nav CONSOLE-2428: i18n for search section of home nav Oct 20, 2020
@ahardin-rh
Copy link

LGTM from the docs side

@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Oct 21, 2020
@spadgett
Copy link
Member

LGTM from the docs side

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Oct 21, 2020
@sferich888
Copy link

sferich888 commented Oct 21, 2020

/label px-approved

@openshift-ci-robot
Copy link
Contributor

@sferich888: The label(s) /label px-approve cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved

In response to this:

/label px-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaianirh
Copy link
Member Author

/label px-approved
/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Oct 21, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 249f578 into openshift:master Oct 21, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants