Bug 1872923: Fix cancel button to return to operator details #6957
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@zherman0: This pull request references Bugzilla bug 1872923, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -104,6 +105,7 @@ type DynamicFormProps = FormProps<any> & { | |||
| ErrorTemplate?: React.FC<{ errors: string[] }>; | |||
| noActions?: boolean; | |||
| customUISchema?: boolean; | |||
| onCancel?: () => void; | |||
There was a problem hiding this comment.
The TypeScript type should match the signature of onClick which takes an event
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@zherman0: All pull requests linked via external trackers have merged: Bugzilla bug 1872923 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cancel button uses goBack which in the case of the new operator install status screen, would go back to the install subscription page instead of the operator details page (which is where you go when you come from operator details page initially).