Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Console plugin init logic is executed only once #6963

Merged
merged 1 commit into from Nov 9, 2020
Merged

Ensure Console plugin init logic is executed only once #6963

merged 1 commit into from Nov 9, 2020

Conversation

vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Oct 20, 2020 •
edited

This PR ensures that even if initConsolePlugins gets called multiple times, its logic is executed only once.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality labels Oct 20, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/git-service Related to git-service component/knative Related to knative-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 20, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2020
@rawagner
Copy link
Contributor

rawagner commented Nov 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f2f0703 into openshift:master Nov 9, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh Awaiting requested review from bipuladh

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/knative Related to knative-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vojtechszocs @rawagner @openshift-ci-robot @spadgett @openshift-merge-robot