Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing key when mapping urls #6964

Merged
merged 1 commit into from Oct 22, 2020
Merged

Add missing key when mapping urls #6964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions frontend/packages/knative-plugin/src/components/overview/RoutesUrlLink.tsx
View file
Open in desktop
Expand Up @@ -10,10 +10,14 @@ const RoutesUrlLink: React.FC<RoutesUrlLinkProps> = ({ urls = [], title }) =>
urls.length > 0 && (
<>
{title && <span className="text-muted">{title}: </span>}
{urls.length > 0 &&
Copy link
Member Author

@jerolimov jerolimov Oct 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check is already done a few lines above

urls.map((url) => (
<ExternalLink href={url} additionalClassName="co-external-link--block" text={url} />
))}
{urls.map((url) => (
<ExternalLink
key={url}
href={url}
text={url}
additionalClassName="co-external-link--block"
/>
))}
</>
);

Expand Down