Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1889698: Fix form re-render on cancelling #6968

Merged
merged 1 commit into from Oct 21, 2020
Merged

Bug 1889698: Fix form re-render on cancelling #6968

merged 1 commit into from Oct 21, 2020

Conversation

afreen23
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1889698

  • dispatch of an action that do not exists causing a reset of redux store.
  • removed the stale dispatch action

Bug 1889698: Fix form re-render on cancelling
2c8654c 
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1889698
- dispatch of an action that do not exists causing a reset of redux store.
- removed the stale dispatch action

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1889698, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889698: Fix form re-render on cancelling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2020
bipuladh
bipuladh reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/console/blob/master/frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/state.ts#L184
We should return the current state instead here too.
This fix is sufficient but let's do this along with it.

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5e26165 into openshift:master Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1889698 has been moved to the MODIFIED state.

In response to this:

Bug 1889698: Fix form re-render on cancelling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 23, 2020
Merged
@openshift-cherrypick-robot
Copy link

@afreen23: new pull request created: #6988

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@rawagner rawagner Awaiting requested review from rawagner

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@afreen23 @openshift-ci-robot @bipuladh @openshift-cherrypick-robot @spadgett @openshift-merge-robot