Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1889515: - Accessibility - The checkmark in the Node > overview page has no text description, label, or other accessible information #6971

Merged
merged 1 commit into from Oct 23, 2020
Merged

Bug 1889515: - Accessibility - The checkmark in the Node > overview page has no text description, label, or other accessible information #6971

merged 1 commit into from Oct 23, 2020

Conversation

cyril-ui-developer
Copy link
Contributor

/assign @jcaianirh
cc: @spadgett

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Bugzilla bug 1889515, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889515: - Accessibility - The checkmark in the Node > overview page has no text description, label, or other accessible information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcaianirh
jcaianirh approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks @cyril-ui-developer

spadgett
spadgett approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we might want to hold for @rhamilto's i18n PR

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@spadgett
Copy link
Member

Disregard, @rhamilto's PR doesn't hit this page since nodes are under Compute now. Thanks @cyril-ui-developer 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/lgtm cancel
Looks like the unit tests need to be updated.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2020
@cyril-ui-developer cyril-ui-developer force-pushed the accessibility-checkmark-node-overview-no-text-desc branch from 4b54afa to 48436d9 Compare October 21, 2020 18:29
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Oct 21, 2020
cyril-ui-developer
cyril-ui-developer commented Oct 21, 2020
View reviewed changes
Copy link
Contributor Author

@cyril-ui-developer cyril-ui-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel
Looks like the unit tests need to be updated.

@spadgett Updated it, thanks!

frontend/packages/console-shared/src/components/status/statuses.tsx
<GenericStatus {...props} Icon={BlueInfoCircleIcon} />
<GenericStatus
{...props}
Icon={() => <BlueInfoCircleIcon className="co-icon-and-text__icon" title="Information" />}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of what title should be here. Just used "Information"

spadgett
spadgett approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 567c50e into openshift:master Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: All pull requests linked via external trackers have merged:

Bugzilla bug 1889515 has been moved to the MODIFIED state.

In response to this:

Bug 1889515: - Accessibility - The checkmark in the Node > overview page has no text description, label, or other accessible information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Oct 26, 2020
@jeff-phillips-18 jeff-phillips-18 mentioned this pull request Oct 29, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

@jcaianirh jcaianirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyril-ui-developer @openshift-ci-robot @spadgett @openshift-bot @jcaianirh @openshift-merge-robot