Add support for Multus(Network) in storage cluster creation under configuration #6974
Conversation
openshift-ci-robot
added
approved
| publicNetwork: null, | ||
| clusterNetwork: null, | ||
| networkType: NetworkType.DEFAULT, |
There was a problem hiding this comment.
update the "StoargeClusterKind" type with networking fields.
| const hasEnabledCreateStep = !!(state.nodes.length >= MINIMUM_NODES && scName); | ||
| // User can't have empty public NAD when using multus | ||
| const hasConfiguredNetwork = | ||
| state.networkType === NetworkType.MULTUS ? !!state.publicNetwork : true; |
There was a problem hiding this comment.
| const hasEnabledCreateStep = !!(state.nodes.length >= MINIMUM_NODES && scName); | |
| // User can't have empty public NAD when using multus | |
| const hasConfiguredNetwork = | |
| state.networkType === NetworkType.MULTUS ? !!state.publicNetwork : true; | |
| // User can't have empty public NAD when using multus | |
| We want to disable the cluster creation step as well. | |
| const hasConfiguredNetwork = | |
| state.networkType === NetworkType.MULTUS ? !!state.publicNetwork : true; | |
| const hasEnabledCreateStep = !!(state.nodes.length >= MINIMUM_NODES && scName && hasConfiguredNetwork ); |
bipuladh
force-pushed
the
multus_converged
branch
from
a903944
to
d2ed349
Compare
openshift-ci-robot
removed
the
needs-rebase
bipuladh
force-pushed
the
multus_converged
branch
from
d2ed349
to
824327e
Compare
|
The UI looks good! Thanks |
| { | ||
| isList: true, | ||
| kind: referenceForModel(NetworkAttachmentDefinitionModel), | ||
| namespace: 'openshift-storage', |
There was a problem hiding this comment.
If the NAD is in openshift-storage namespace, then it can't be used in other namespaces.
For example, an application using OCS as storage backend which is in namespace other than openshift-storage won't be able to utilize multus.
Only the NADs in the default namespace can be used accross namespaces. So we need to list NADs from the default namespace as well.
The NADs from the default namespace is referenced as default/<name-of-NAD> in the network spec
e.g.,
public: "default/ocs-public-nw"
cluster: "default/ocs-cluster-nw"
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
19 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
bipuladh
force-pushed
the
multus_converged
branch
from
824327e
to
4f3dba5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Screenshot:
Validations: