Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1890614: Fix Cypress test flake and accesibility violation: 'Ensures buttons have discernible text' #6981

Merged
merged 1 commit into from
Dec 3, 2020
Merged

[release-4.6] Bug 1890614: Fix Cypress test flake and accesibility violation: 'Ensures buttons have discernible text' #6981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
/frontend/npm-debug.log
/frontend/yarn-error.log
/frontend/gui_test_screenshots
/frontend/packages/integration-tests-cypress/cypress-a11y-report.json
/frontend/@types
1 change: 1 addition & 0 deletions frontend/packages/integration-tests-cypress/tests/crud/k8-openshift-cruds.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ describe('Kubernetes resource CRUD operations', () => {

it('displays detail view for newly created resource instance', () => {
cy.url().should('include', `/${name}`);
detailsPage.isLoaded();
detailsPage.titleShouldContain(name);
cy.testA11y(`Details page for ${kind}: ${name}`);
});
Expand Down
1 change: 1 addition & 0 deletions frontend/packages/integration-tests-cypress/views/details-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const detailsPage = {
.contains(action)
.click();
},
isLoaded: () => cy.byTestID('skeleton-detail-view').should('not.exist'),
};

export namespace DetailsPageSelector {
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/utils/field-level-help.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const FieldLevelHelp: React.FC<FieldLevelHelpProps> = React.memo(({ child
}
return (
<Popover aria-label="Help" bodyContent={children} enableFlip>
<Button variant="link" isInline className="co-field-level-help">
<Button aria-label="Help" variant="link" isInline className="co-field-level-help">
<QuestionCircleIcon className="co-field-level-help__icon" />
</Button>
</Popover>
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/utils/horizontal-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export const HorizontalNav = React.memo((props: HorizontalNavProps) => {
const content = <Switch> {routes} </Switch>;

const skeletonDetails = (
<div className="skeleton-detail-view">
<div data-test="skeleton-detail-view" className="skeleton-detail-view">
<div className="skeleton-detail-view--head" />
<div className="skeleton-detail-view--grid">
<div className="skeleton-detail-view--column">
Expand Down