Bug 1889724: When LocalVolumeDiscovery CR is created form the LSO page , user must see the Disk tab

[afreen23]

• The flag is set only by OCS and gets undefined when OCS is not installed. The flag must be set by LSO plugin and imported in OCS.
• Created an action flag in LSO package to be set
• Looking for discovery CR rather than discoveryresult CR
• minor fix for empty state too

[openshift-ci-robot]

@afreen23: This pull request references Bugzilla bug 188972, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.7.0" release, but it targets "---" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 188972: Fix flag setting for disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@afreen23: This pull request references Bugzilla bug 188972, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.7.0" release, but it targets "---" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 188972: Fix flag setting for disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@afreen23: This pull request references Bugzilla bug 1889724, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889724: Fix flag setting for disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bipuladh]

Please attach screenshots of the fix.

[openshift-ci-robot]

@afreen23: This pull request references Bugzilla bug 1889724, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889724: When LocalVolumeDiscovery CR is created form the LSO page , user must Disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@afreen23: This pull request references Bugzilla bug 1889724, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889724: When LocalVolumeDiscovery CR is created form the LSO page , user must Disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bipuladh]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/ceph-storage-plugin/OWNERS [afreen23,bipuladh]
• frontend/packages/local-storage-operator-plugin/OWNERS [afreen23,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@afreen23: All pull requests linked via external trackers have merged:

• openshift/console#6986

Bugzilla bug 1889724 has been moved to the MODIFIED state.

In response to this:

Bug 1889724: When LocalVolumeDiscovery CR is created form the LSO page , user must Disk tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afreen23]

/cherrypick release-4.6

[openshift-cherrypick-robot]

@afreen23: #6986 failed to apply on top of branch "release-4.6":

Applying: Bug 1889724: Fixed disk tab enablement for only LSO installation
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/create-sc.tsx
M	frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/install-lso-sc.tsx
M	frontend/packages/ceph-storage-plugin/src/features.ts
M	frontend/packages/ceph-storage-plugin/src/plugin.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/ceph-storage-plugin/src/plugin.ts
Auto-merging frontend/packages/ceph-storage-plugin/src/features.ts
Auto-merging frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/install-lso-sc.tsx
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/install-lso-sc.tsx
Auto-merging frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/create-sc.tsx
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/create-sc.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1889724: Fixed disk tab enablement for only LSO installation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.