Bug 1887864: Update library-go and replace runc module for v1.0.0-rc8 version #6990
Conversation
|
@jhadvig: This pull request references Bugzilla bug 1887864, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
go.mod
Outdated
| @@ -30,7 +30,8 @@ require ( | |||
| replace ( | |||
| // ww/goautoneg repo does not exist on butbucket anymore, hence we | |||
| // need to use a mirror. It can be removed when we update to newer libary-go | |||
| bitbucket.org/ww/goautoneg => github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 | |||
| // bitbucket.org/ww/goautoneg => github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 | |||
There was a problem hiding this comment.
@pedjak double checking if its ok to remove
There was a problem hiding this comment.
I think it is.. otherwise, you would not be able to do perform go mod vendor
jhadvig
changed the title
go.mod
Outdated
| @@ -33,4 +34,5 @@ replace ( | |||
| bitbucket.org/ww/goautoneg => github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 | |||
There was a problem hiding this comment.
this line (and the comment) can be removed now, given that library-go is getting updated in this PR
There was a problem hiding this comment.
@pedjak comment addressed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-gcp-console |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jhadvig: All pull requests linked via external trackers have merged: Bugzilla bug 1887864 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@jhadvig: new pull request created: #7022 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @spadgett
cc'ing @pedjak for additional review