Made singulars for Insights plugin #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/insights
spadgett
reviewed
Oct 23, 2020
| @@ -36,7 +36,7 @@ export const InsightsPopup: React.FC<PrometheusHealthPopupProps> = ({ responses, | |||
| y: v, | |||
| }))} | |||
| title={`${numberOfIssues}`} | |||
| subTitle="Total issues" | |||
| subTitle={`Total ${numberOfIssues > 1 ? 'issues' : 'issue'}`} | |||
There was a problem hiding this comment.
Suggested change
| subTitle={`Total ${numberOfIssues > 1 ? 'issues' : 'issue'}`} | |
| subTitle={`Total ${numberOfIssues === 1 ? 'issue' : 'issues'}`} |
This is better in general since you want "0 issues" if it's ever 0. I realize that hasIssues should be false here, but I'd rather code defensively in case that ever changes.
bond95
force-pushed
the
singulars-prulars-issues
branch
from
f513993
to
f26b08a
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bond95, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
issueslabel for single issue. PTAL @vojtechszocs @spadgett @doruskova