Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cnv base images loading #6999

Merged
merged 1 commit into from Oct 27, 2020

Conversation

atiratree
Copy link
Member

  • remove code duplication for checking checking the common data changes
  • disable relevant fields until cnvBaseImages are loaded plus allow for non admin user as well
  • ensure redux format consistency

continuation of #6704

- remove code duplication for checking checking the common data changes
- disable relevant fields until cnvBaseImages are loaded plus allow for non admin user as well
- ensure redux format consistency
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2020
@atiratree
Copy link
Member Author

/retest

@glekner
Copy link
Contributor

glekner commented Oct 27, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit a580a96 into openshift:master Oct 27, 2020
@spadgett spadgett added this to the v4.7 milestone Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants