Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1812412: Monitoring: Increase Prometheus query_range timeouts to 30s #7004

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Oct 27, 2020

The current timeout of 5 seconds is probably much too strict.

Prometheus has a maximum concurrent queries limit, which is currently
set to 20. This should protect against overloading Prometheus, even if
we increase the timeout significantly.

Also, if there are more than 20 queries, some will be queued and the
time they spend in the queue will count towards the time limit, which is
another reason to make the timeout less strict.

The current timeout of 5 seconds is probably much too strict.

Prometheus has a maximum concurrent queries limit, which is currently
set to 20. This should protect against overloading Prometheus, even if
we increase the timeout significantly.

Also, if there are more than 20 queries, some will be queued and the
time they spend in the queue will count towards the time limit, which is
another reason to make the timeout less strict.
@openshift-ci-robot
Copy link
Contributor

@kyoto: An error was encountered adding this pull request to the external tracker bugs for bug 1812412 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1812412: Monitoring: Increase Prometheus query_range timeouts to 30s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2020
@kyoto
Copy link
Member Author

kyoto commented Oct 27, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kyoto: An error was encountered adding this pull request to the external tracker bugs for bug 1812412 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto
Copy link
Member Author

kyoto commented Oct 27, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kyoto: An error was encountered adding this pull request to the external tracker bugs for bug 1812412 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor

/approve

@spadgett
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@spadgett: An error was encountered adding this pull request to the external tracker bugs for bug 1812412 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, s-urbaniak, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b3522fa into openshift:master Oct 27, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: All pull requests linked via external trackers have merged:

Bugzilla bug 1812412 has been moved to the MODIFIED state.

In response to this:

Bug 1812412: Monitoring: Increase Prometheus query_range timeouts to 30s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Oct 27, 2020
@kyoto kyoto deleted the monitoring-increase-prometheus-api-timeouts branch October 28, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants