Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2431: i18n for home/api-explorer #7009

Merged
merged 2 commits into from Dec 7, 2020

Conversation

jcaianirh
Copy link
Member

For: https://issues.redhat.com/browse/CONSOLE-2431

Addresses api explorer section in the home navigation

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Oct 27, 2020
Copy link
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a couple of capitalization questions.

frontend/public/components/api-explorer.tsx Show resolved Hide resolved
frontend/public/components/api-explorer.tsx Show resolved Hide resolved
frontend/public/components/api-explorer.tsx Show resolved Hide resolved
@jcaianirh
Copy link
Member Author

/retest

1 similar comment
@jcaianirh
Copy link
Member Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
LGTM, please squash

/hold for other approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@yapei
Copy link
Contributor

yapei commented Nov 20, 2020

@jcaianirh I created a cluster with command launch openshift/console#7009 then I visited api-explorer page with two methods:

  1. Adding ?lng=ja suffix to URL which is <console_route>/api-explorer?lng=ja
  2. Changed browser setting to ja and refresh the <console_route>/api-explorer page

However neither way shows me the Japanese translation, nothing is translated

@jcaianirh
Copy link
Member Author

@yapei These strings have not yet been translated into any language. You can see the changes by using pseudolocalization url param

@yapei
Copy link
Contributor

yapei commented Nov 20, 2020

@yapei These strings have not yet been translated into any language. You can see the changes by using pseudolocalization url param

using pseudolocalization url param does it mean adding ?lng=en suffix or something?

@rebeccaalpert
Copy link
Contributor

Hey @yapei - ?pseudolocalization=true&lng=en is the correct parameter.

@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Nov 20, 2020
@yapei
Copy link
Contributor

yapei commented Nov 23, 2020

@jcaianirh Is the string Select all filters should be translated?
Screen Shot 2020-11-23 at 11 33 57 AM

@jcaianirh
Copy link
Member Author

jcaianirh commented Nov 23, 2020

@yapei thanks, the toolbar is a common component, the common components will be addressed as a separate pr. The first 3 items are passed in by the api-explorer, and the "Select all filters" is provided by the common component. It will be translated when the common components are translated.

@rebeccaalpert
Copy link
Contributor

We've already completed/merged the common components story and this was not included. I added a comment to https://issues.redhat.com/browse/CONSOLE-2474 about this piece of text so it doesn't get lost.

@jcaianirh
Copy link
Member Author

@yapei this is ready for qe review, the note you added about select all filters will be fixed in another pr. thanks!

@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

Thank you all @jcaianirh @rebeccaalpert
I understand that the issue I mentioned will come in another PR

@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Nov 25, 2020
@sferich888
Copy link

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Nov 30, 2020
@sferich888
Copy link

/unassign @sferich888

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Leaving the hold, however, since we're over our SLO. We can remove the hold when our bug count drops.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Dec 7, 2020

Removing the hold since we're below our SLO.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8e92a26 into openshift:master Dec 7, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants