New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2431: i18n for home/api-explorer #7009
CONSOLE-2431: i18n for home/api-explorer #7009
Conversation
afe7d16
to
e75de41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a couple of capitalization questions.
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM, please squash
/hold for other approvals
/assign @yapei @ahardin-rh @sferich888
@jcaianirh I created a cluster with command
However neither way shows me the Japanese translation, nothing is translated |
@yapei These strings have not yet been translated into any language. You can see the changes by using pseudolocalization url param |
|
Hey @yapei - |
/label docs-approved |
@jcaianirh Is the string |
@yapei thanks, the toolbar is a common component, the common components will be addressed as a separate pr. The first 3 items are passed in by the api-explorer, and the "Select all filters" is provided by the common component. It will be translated when the common components are translated. |
We've already completed/merged the common components story and this was not included. I added a comment to https://issues.redhat.com/browse/CONSOLE-2474 about this piece of text so it doesn't get lost. |
@yapei this is ready for qe review, the note you added about select all filters will be fixed in another pr. thanks! |
Thank you all @jcaianirh @rebeccaalpert |
/label qe-approved |
/label px-approved |
/unassign @sferich888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Leaving the hold, however, since we're over our SLO. We can remove the hold when our bug count drops.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removing the hold since we're below our SLO. /hold cancel |
For: https://issues.redhat.com/browse/CONSOLE-2431
Addresses api explorer section in the home navigation