Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cloudinit doc link #7015

Merged
merged 1 commit into from Nov 2, 2020
Merged

add cloudinit doc link #7015

merged 1 commit into from Nov 2, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Oct 28, 2020

Screen Shot 2020-10-28 at 15 52 44

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1882246, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DEFERRED) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882246: add cloudinit doc link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Oct 28, 2020
@glekner glekner changed the title Bug 1882246: add cloudinit doc link add cloudinit doc link Oct 28, 2020
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

add cloudinit doc link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glekner
Copy link
Contributor Author

glekner commented Oct 28, 2020

@matthewcarleton is the placement and text of the doc btn ok?

@matthewcarleton
Copy link
Contributor

I'd like to pull in @yfrimanm here. IMO we should provide some inline help and then send them off to the docs if they want to learn more.

@yfrimanm
Copy link

yfrimanm commented Oct 29, 2020 •
edited

@glekner WDYT?
Cloud-init

@glekner
Copy link
Contributor Author

glekner commented Oct 29, 2020

Updated to a helper with a new text with the help of Tomas

image

@yfrimanm @matthewcarleton

@yfrimanm
Copy link

yfrimanm commented Oct 29, 2020 via email

atiratree
atiratree reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@atiratree atiratree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

...kages/kubevirt-plugin/src/components/create-vm-wizard/tabs/cloud-init-tab/cloud-init-tab.tsx Outdated
@@ -302,7 +307,39 @@ const CloudInitTabComponent: React.FC<ResultTabComponentProps> = ({
)}
<Form>
<Title headingLevel="h5" size="lg">
Cloud-init
Cloud-init{' '}
<Popover
Copy link
Member

@atiratree atiratree Oct 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please move this to a standalone component as this is component is quite big already?

...kages/kubevirt-plugin/src/components/create-vm-wizard/tabs/cloud-init-tab/cloud-init-tab.tsx Outdated
<StackItem>
<ExternalLink
text="Learn more"
href="https://cloudinit.readthedocs.io/en/latest/index.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracting it to constant would be probably better

@glekner
Copy link
Contributor Author

glekner commented Nov 1, 2020

created a new component @suomiy

@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5455583 into openshift:master Nov 2, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree left review comments

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@glekner @openshift-ci-robot @matthewcarleton @yfrimanm @atiratree @spadgett @openshift-merge-robot