Fix po-to-i18n script #7016
Merged
Fix po-to-i18n script #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
force-pushed
the
po-to-i18n
branch
from
c13b954
to
1dd1886
Compare
spadgett
reviewed
Oct 28, 2020
frontend/.eslintignore
Outdated
| @@ -7,3 +7,4 @@ public/lib | |||
| Godeps | |||
| @types | |||
| dynamic-demo-plugin | |||
| i18n-scripts | |||
There was a problem hiding this comment.
We probably want to keep linting, just use a different eslintrc in the i18n-scripts folder with different rules.
There was a problem hiding this comment.
I moved in an eslintrc file; I'm still going through there and removing things that aren't necessary for this folder.
rebeccaalpert
force-pushed
the
po-to-i18n
branch
from
1dd1886
to
e63a1d1
Compare
File structure change broke the script. I fixed that and added better handling for nonexistent directories and bad file names. I also updated .eslintignore so we could remove comments.
rebeccaalpert
force-pushed
the
po-to-i18n
branch
from
e63a1d1
to
07fbc3d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize recent file structure changes broke the script. I fixed that and added better handling for nonexistent directories and bad file names. I also updated .eslintignore so we could remove "ignore me linter!" comments.