Bug 1895423: Show custom builder image in edit flows BuilderImage section #7021
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
divyanshiGupta
force-pushed
the
jira-issue#5015
branch
from
d00d83a
to
8413094
Compare
divyanshiGupta
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc: @rohitkrai03 |
divyanshiGupta
force-pushed
the
jira-issue#5015
branch
2 times, most recently
from
3474f34
to
843ae29
Compare
|
@divyanshiGupta git url validation is stuck in an infinite loop. |
Couldnt reproduce the issue. Please let me know the steps to reproduce it. |
divyanshiGupta
force-pushed
the
jira-issue#5015
branch
4 times, most recently
from
14b6e0c
to
b7c88b3
Compare
frontend/packages/dev-console/src/components/edit-application/EditApplication.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/import/git/GitSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/import/git/GitSection.tsx
Outdated
Show resolved
Hide resolved
divyanshiGupta
force-pushed
the
jira-issue#5015
branch
from
b7c88b3
to
854677d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, divyanshiGupta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
divyanshiGupta
changed the title
|
@divyanshiGupta: All pull requests linked via external trackers have merged: Bugzilla bug 1895423 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.6 |
|
@divyanshiGupta: new pull request created: #7147 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5015
Analysis / Root cause:
Application is not editable if a custom builder image is used
Solution Description:
Show a new tile for the custom builder image in builder section of edit flows
Screen shots / Gifs for design review:
Unit test coverage report:
Browser conformance: