Fix application dropdown to fetch resources based on extensions.

[jeff-phillips-18]

Fixes:
https://issues.redhat.com/browse/ODC-3613

Solution Description:
Use the topology plugin extensions to determine which resource kinds to fetch to then search for existing application groupings.

Browser conformance:

• [x ] Chrome
• Firefox
• Safari
• Edge

[jeff-phillips-18]

/retest

[debsmita1]

Suggested change

	placeholder={t('devconsole~Select application')}
	placeholder={t('devconsole~Select an application')}

unsure if we need to take care of localization in this PR 'cause PR #6905 takes care of all the files under dev-console

[jeff-phillips-18]

afaik, the ask was to make sure any PRs do the i18n work as well in order to help ensure things are not missed.

[christianvogt]

This works fine. However we are severely overfetching resources now.
There is no efficient way to properly identify all the applications within a namespace.
cc @serenamarie125 as this problem will continue to get worse.

[christianvogt]

Do you need kindsInFlight? Seems like you can rely on loaded of the watched resources. kindsInFlight will include every resource that's currently in flight from anywhere on the page.

[jeff-phillips-18]

Initially loaded can return true with load errors for every resource fetched when kindsInFlight is true. This results in an error being shown briefly.

[jeff-phillips-18]

I've put a fix into useK8sWatchResources to not set the loaded flag to true when the model is not loaded and kinds are still in flight. @rawagner PTAL

[christianvogt]

/approve

@rawagner please have a look at the change to k8s-watch-hook.ts

[rawagner]

I think that everytime we get here we can say that either all models are loaded or all requested models are loaded -

console/frontend/public/components/utils/k8s-watch-hook.ts

Line 144 in 6fc7a2d

const hasAllModelsLoaded = React.useMemo(() => modelsLoaded || k8sModels.every((m) => !!m), [

. That means its safe to say resource is not being loaded anymore and the model is missing. Or I missed something, do you have a case which I can try that causes the issue ?

modelsLoaded is also missing in dependency array

console/frontend/public/components/utils/k8s-watch-hook.ts

Line 230 in 6fc7a2d

}, [reduxIDs, JSON.stringify(resources), resourceK8s, noModels]);

[rawagner]

@jeff-phillips-18 I guess I see the problem. Can you change hasAllModelsLoaded to

const hasAllModelsLoaded = React.useMemo(
    () => modelsLoaded || Object.values(resources).every((r) => k8sModels.includes(r.kind)),
    [k8sModels, modelsLoaded, resources],
  );

and revert other changes ? That might help

[rawagner]

@jeff-phillips-18 I've updated my PR #6464 with some more changes which should resolve your issues. Can you try ?

[jeff-phillips-18]

@rawagner I'll give that a try. I definitely saw instances where all models returned loaded: true here while modelsLoaded was false.

[rawagner]

@jeff-phillips-18 makes sense, hasAllModelsLoaded was broken because second part (after or operator) was just wrong.

[jeff-phillips-18]

Yes, that fixes the issue I was seeing. Thanks, I will remove my changes to k8s-watch-hook.ts

[christianvogt]

@jeff-phillips-18 do we wait for the related bug to be fixed or are we sticking with this small fix to the k8s-watch-hook?

[jeff-phillips-18]

@jeff-phillips-18 do we wait for the related bug to be fixed or are we sticking with this small fix to the k8s-watch-hook?

No, we can go in without the change. Just can't update TopologyDataRetriever until the fix to the hook goes in.

[jeff-phillips-18]

@christianvogt #6464 has merged. This PR should be ready now.

[christianvogt]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment