Console-2450: i18n for jobs #7036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @spadgett |
spadgett
reviewed
Oct 29, 2020
spadgett
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
/lgtm
/hold
/assign @yapei @ahardin-rh @sferich888
This is ready for QE review. @yapei This covers only the job pages (not cron jobs).
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
lgtm
|
/label px-approved |
openshift-ci-robot
added
the
px-approved
|
/label qe-approved |
openshift-ci-robot
added
the
qe-approved
spadgett
added
the
needs-rebase
|
@zherman0 FYI, needs rebase |
|
/label docs-approved |
openshift-ci-robot
added
the
docs-approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console-2450: i18n for workloads - jobs