New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1893022: Fix git validation on selecting git type #7046
Bug 1893022: Fix git validation on selecting git type #7046
Conversation
@nemesis09: This pull request references Bugzilla bug 1893022, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@nemesis09: This pull request references Bugzilla bug 1893022, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff is similar to the original PR.
Tested the branch locally and it works fine.
/lgtm
/bugzilla refresh
@jerolimov: This pull request references Bugzilla bug 1893022, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jerolimov, nemesis09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@nemesis09: All pull requests linked via external trackers have merged: Bugzilla bug 1893022 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry Pick PR for #5706
Fixes:
https://issues.redhat.com/browse/ODC-4044
Analysis / Root cause:
when git type is not known, the git url is not validated after git type is explicitly selected from the git type dropdown
Solution Description:
validate git url after a git type is selected from the dropdown
Screens:
Test Coverage:
Browser Conformance: