Selects the default class or the first item in SnapshotClassDropdown

[vbnrh]

https://issues.redhat.com/browse/RHSTOR-1345

Signed-off-by: Vineet Badrinath vbadrina@redhat.com

[vbnrh]

@afreen23 @a2batic @bipuladh Please test and review.

[vbnrh]

/assign @afreen23 @a2batic @bipuladh

[afreen23]

The ListDropdown is used at several places, are we sure we want to change the behavior for all ?
Moreover, you can use the selectedKey option to pass a pre selected item.

[cloudbehl]

The ListDropdown is used at several places, are we sure we want to change the behavior for all ?
Moreover, you can use the selectedKey option to pass a pre selected item.

I agree we can use selectedKey and pass the 0th element of an array if we don't have default classes.

[vbnrh]

@cloudbehl @afreen23 Could you guys let me know on how we could use the selectedKey to use the 0th element of an array ? As per my understanding, the selectedKey needs a string value from an item in the array. We don't have the arrays available as a return value for using the first element in the create-volume-snapshot.tsx and passing it as selected key to listdropdown. Hence, i passed a prop from SnapshotClassDropdown to the listdropdown and select whatever is the first value there.

The ListDropdown is used at several places, are we sure we want to change the behavior for all

Which is why i introduced a prop, we are only changing the behavior of SnapshotClassDropdown.

[afreen23]

@cloudbehl @afreen23 Could you guys let me know on how we could use the selectedKey to use the 0th element of an array ? As per my understanding, the selectedKey needs a string value from an item in the array. We don't have the arrays available as a return value for using the first element in the create-volume-snapshot.tsx and passing it as selected key to listdropdown. Hence, i passed a prop from SnapshotClassDropdown to the listdropdown and select whatever is the first value there.

The ListDropdown is used at several places, are we sure we want to change the behavior for all

Which is why i introduced a prop, we are only changing the behavior of SnapshotClassDropdown.

Firstly, Pr without description/jira/BZs are very hard to follow.
And checking on the current behavior, we do show the "select snapshot class" placeholder,

So why do we want to pre-select a random snapshot class ?

Thanks!

[vbnrh]

@cloudbehl @afreen23 Could you guys let me know on how we could use the selectedKey to use the 0th element of an array ? As per my understanding, the selectedKey needs a string value from an item in the array. We don't have the arrays available as a return value for using the first element in the create-volume-snapshot.tsx and passing it as selected key to listdropdown. Hence, i passed a prop from SnapshotClassDropdown to the listdropdown and select whatever is the first value there.

The ListDropdown is used at several places, are we sure we want to change the behavior for all

Which is why i introduced a prop, we are only changing the behavior of SnapshotClassDropdown.

Firstly, Pr without description/jira/BZs are very hard to follow.
And checking on the current behavior, we do show the "select snapshot class" placeholder,

So why do we want to pre-select a random snapshot class ?

Thanks!

@afreen23 Sorry ! forgetting to link the JIRAs i am addressing.
This is to address https://issues.redhat.com/browse/RHSTOR-1345

We don't want to show "Select volume snapshot class" instead we'd like to already pre-select the default or the first item in the list.

[a2batic]

So why do we want to pre-select a random snapshot class ?

@afreen23 It was suggested by UX team to pre-select snapshot class from the dropdown as an enhancement. The dropdown contains filtered options, so selecting any key from dropdown should work.
@yuvalgalanti ^^

[afreen23]

So why do we want to pre-select a random snapshot class ?

@afreen23 It was suggested by UX team to pre-select snapshot class from the dropdown as an enhancement. The dropdown contains filtered options, so selecting any key from dropdown should work.
@yuvalgalanti ^^

It makes sense to pass the default storage class (if present) as selected from your parent component and let the user choose then any snapshot class.

[yuvalgalanti]

So why do we want to pre-select a random snapshot class ?

@afreen23 It was suggested by UX team to pre-select snapshot class from the dropdown as an enhancement. The dropdown contains filtered options, so selecting any key from dropdown should work.
@yuvalgalanti ^^

It makes sense to pass the default storage class (if present) as selected from your parent component and let the user choose then any snapshot class.

@afreen23 +1 If we are able to choose it by default we should do that.

[cloudbehl]

define types for the variable declared

[cloudbehl]

nit

[a2batic]

/lgtm
Working fine, tested locally.

[rawagner]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, rawagner, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vbnrh: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/kubevirt-plugin	950e1d5	link	/test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.