not all disk types can be selected as the boot source #7080
Conversation
|
@matthewcarleton @jelkosz can you approve the validation message |
|
@suomiy can you review |
| <FormSelectOption key={storage.id} value={storage.id} label={storage.disk?.name} /> | ||
| ), | ||
| )} | ||
| {ignoreCaseSort(storages, null, (storage) => storage.disk?.name).map((storage) => ( |
There was a problem hiding this comment.
why are we including the disks they cannot select?
| @@ -1,3 +1,5 @@ | |||
| export const ATTACH_CD = 'Attach CD-ROM'; | |||
| export const NO_BOOTABLE_ATTACHED_DISK_ERROR = 'A bootable attached disk could not be found'; | |||
| export const BOOTABLE_ATTACHED_DISK_MESSAGE = 'Boot disks can not have a blank source'; | |||
There was a problem hiding this comment.
blank source has a special meaning. Shouldn't we say something like that selecting a boot source is required?
There was a problem hiding this comment.
@matthewcarleton can you jump in?
There was a problem hiding this comment.
What we want to communicate is that the disk they are selecting must have a source defined and can not be blank.
Could we say:
"A boot source disk must have a source and can not be blank"
There was a problem hiding this comment.
not sure if we want to mention other invalid sources (which is not just blank type), but ok let's put this message
glekner
force-pushed
the
update-storagebootsource
branch
from
1792c00
to
f9ff625
Compare
openshift-ci-robot
added
the
approved
|
added |
|
+1, just this left #7080 (comment) |
glekner
force-pushed
the
update-storagebootsource
branch
from
f9ff625
to
e6f2a85
Compare
|
@suomiy updated string |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glekner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.