Bug 1894330: update channels list #7096
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@yapei: This pull request references Bugzilla bug 1894330, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@yapei: This pull request references Bugzilla bug 1894330, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yapei: This pull request references Bugzilla bug 1894330, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp-console |
|
Hi, @yapei. This should no longer be necessary as we now get the list of channels from the API since #6283, although I see you're updating the fallback. It might be better to just remove the fallback so we don't have to maintain this release-to-release. The ClusterVersion API should have the valid values. cc @rhamilto |
Yeah. We should remove the fallback and there is also a TODO to not link to the modal if |
|
@rhamilto yes - I do. I will circle back with you offline and get that taken care of. |
|
IMO, we should probably close this PR since we don't want to remove the fallback without implementing the pending design changes at the same time as we'll end up with a modal containing no options in the dropdown if we do. |
|
@megan-hall's design story is https://issues.redhat.com/browse/PD-579 |
|
Got it, let me close the PR |
|
@yapei: This pull request references Bugzilla bug 1894330. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Let's go ahead and update the fallback for now so it's not wrong, and we can circle back when we have a design for when there are no channels. /reopen |
|
@yapei: This pull request references Bugzilla bug 1894330, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@yapei: All pull requests linked via external trackers have merged: Bugzilla bug 1894330 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updated channels list for 4.7