Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894810: removes techpreview badge from eventing #7110

Merged
merged 1 commit into from Nov 12, 2020

Conversation

invincibleJai
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-5045

Analysis / Root cause:
Eventing is going GA, so needed to remove TP badge from

  • Add Channel
  • EventSource creation
  • Eventing CR creation

Solution Description:
Removed TP badge from Eventing components

Screen shots / Gifs for design review:

  • Eventing CR:

image

image

  • Add Channel

image

  • EventSources

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@invincibleJai invincibleJai changed the title Bug 1894810removes techpreview badge from eventing Bug 1894810: removes techpreview badge from eventing Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: This pull request references Bugzilla bug 1894810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1894810: removes techpreview badge from eventing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2020
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 208cb41 into openshift:master Nov 12, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: All pull requests linked via external trackers have merged:

Bugzilla bug 1894810 has been moved to the MODIFIED state.

In response to this:

Bug 1894810: removes techpreview badge from eventing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
@invincibleJai
Copy link
Member Author

/cherry-pick release-4.6

@openshift-cherrypick-robot

@invincibleJai: #7110 failed to apply on top of branch "release-4.6":

Applying: removes techpreview badge from eventing
Using index info to reconstruct a base tree...
M	frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
M	frontend/packages/knative-plugin/src/components/add/EventingChannelPage.tsx
M	frontend/packages/knative-plugin/src/models.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/knative-plugin/src/models.ts
Auto-merging frontend/packages/knative-plugin/src/components/add/EventingChannelPage.tsx
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/components/add/EventingChannelPage.tsx
Auto-merging frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 removes techpreview badge from eventing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants