Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894860: fixed test "returned merged index file for all accessible helm repos" #7111

Merged
merged 1 commit into from Nov 6, 2020

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Nov 5, 2020

Previously, the test was using the wrong file for verifying the expectations. azureRepoIndex.yaml is processed on the fly and entry names are changed to contain the repo origin name. Thus, mergedAzureRepoIndex.yaml should reflect that.

This test is failing at the moment on all open PRs, but it is not reported back to GitHub (ci/prow/backend is green) and hence everything looks great for merge. After merging this PR, it should be investigated why CI is behaving this way.

cc @spadgett

Previously, the test was using the wrong file for verifying the expectations.
@openshift-ci-robot openshift-ci-robot added the component/backend Related to backend label Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@pedjak pedjak changed the title fixed test "returned merged index file for all accessible helm repos" Bug 1894860: fixed test "returned merged index file for all accessible helm repos" Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

@pedjak: This pull request references Bugzilla bug 1894860, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1894860: fixed test "returned merged index file for all accessible helm repos"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

@pedjak: This pull request references Bugzilla bug 1894860, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/cherry-pick release-4.6

@openshift-cherrypick-robot

@pedjak: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@pedjak: This pull request references Bugzilla bug 1894860, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1894860: fixed test "returned merged index file for all accessible helm repos"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@pedjak: This pull request references Bugzilla bug 1894860, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1894860: fixed test "returned merged index file for all accessible helm repos"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member

jhadvig commented Nov 5, 2020

/test e2e-gcp-console

@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/retest

3 similar comments
@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Nov 5, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Nov 6, 2020

/retest

@akashshinde
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 209ee4f into openshift:master Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@pedjak: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1894860 has not been moved to the MODIFIED state.

In response to this:

Bug 1894860: fixed test "returned merged index file for all accessible helm repos"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@pedjak: new pull request created: #7149

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants